[bitnami/redis-cluster] Remove Jobs #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel A. Cabrera Minagorri <[email protected]>
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
javsalgar
approved these changes
Apr 21, 2021
| @@ -113,19 +119,27 @@ spec: | |||
| echo COPYING FILE | |||
| cp /opt/bitnami/redis/etc/redis-default.conf /opt/bitnami/redis/etc/redis.conf | |||
| fi | |||
| {{- if .Values.cluster.init }} | |||
| pod_index=($(echo "$POD_NAME" | tr "-" "\n")) | |||
There was a problem hiding this comment.
Is the extra bracket necessary?
There was a problem hiding this comment.
Yes, it will return an array, and the next line indexes that array to get the latest element
Signed-off-by: Bitnami Containers <[email protected]>
|
I have just updated the bitnami images with the latest known immutable tags:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel A. Cabrera Minagorri [email protected]
Description of the change
This PR removes the Jobs in order o be able to install the chart with helm template + kubectl.
About the update cluster job, since it is a totally optional component that can be run or not to update the cluster nodes, I think it is not needed to remove it.
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[bitnami/chart])