Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Fix issues in initialization/restarts #5603

Merged
merged 10 commits into from
Feb 24, 2021

Conversation

rafariossaa
Copy link
Contributor

@rafariossaa rafariossaa commented Feb 24, 2021

Description of the change

I noticed kubernetes DNS issues when running the chart, and also sentinels did not clean its sentinels list of nodes.

The DNS issues consists in that starting node IP take a while to be added to the headless service DNS entry, so a wait was added to ensure that DNS content is reliable.
On sentinel nodes list issu, when a node is restarted it is added to the sentinel list, but the old one is not cleaned. This lead to sentinels think that they are more nodes than the actually existing hence there won't be quorum to elect a new master if needed.

Benefits

This should fix starting issues that lied to having more than one master and issues where a master was not promoted.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

@rafariossaa rafariossaa changed the title [bitnami/redis] Fix issues in initializacion/restarts [bitnami/redis] Fix issues in initialization/restarts Feb 24, 2021
bitnami/redis/README.md Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
bitnami/redis/templates/configmap-scripts.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafariossaa
Copy link
Contributor Author

Thanks !
I am merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis sentinel is not picking right master after master pod restart
3 participants