-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/redis] Fix issues in initialization/restarts #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javsalgar
reviewed
Feb 24, 2021
rafariossaa
changed the title
[bitnami/redis] Fix issues in initializacion/restarts
[bitnami/redis] Fix issues in initialization/restarts
Feb 24, 2021
juan131
requested changes
Feb 24, 2021
juan131
reviewed
Feb 24, 2021
juan131
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
I noticed kubernetes DNS issues when running the chart, and also sentinels did not clean its sentinels list of nodes.
The DNS issues consists in that starting node IP take a while to be added to the headless service DNS entry, so a wait was added to ensure that DNS content is reliable.
On sentinel nodes list issu, when a node is restarted it is added to the sentinel list, but the old one is not cleaned. This lead to sentinels think that they are more nodes than the actually existing hence there won't be quorum to elect a new master if needed.
Benefits
This should fix starting issues that lied to having more than one master and issues where a master was not promoted.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.[bitnami/chart]
)