[bitnami/external-dns] allow gcp project autodetection #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: afirth <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
|
I have just updated the bitnami images with the latest known immutable tags:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Don't set the argument
--google-projectunless a value is provided. Without this argument, autodetection will happen as intended.Benefits
kubernetes-sigs/external-dns#492 and kubernetes-sigs/external-dns#494 added autodetection of the GCP project, but the empty value provided in
values.yamlis still picked up if the arg--google-project=is provided. The args override the env varEXTERNAL_DNS_GOOGLE_PROJECT, meaning this can only be overridden by patching the args array.Applicable issues
kubernetes-sigs/external-dns/492 and kubernetes-sigs/external-dns/494
Checklist
Chart.yamlaccording to semver.[bitnami/chart])[edited 2020-06-15 - it does work as is, but can't be overridden]