Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitnami/logstash fix: support NodePorts in bitnami logstash chart #18474

Closed
wants to merge 0 commits into from
Closed

bitnami/logstash fix: support NodePorts in bitnami logstash chart #18474

wants to merge 0 commits into from

Conversation

cbrwflo
Copy link
Contributor

@cbrwflo cbrwflo commented Aug 16, 2023

Description of the change

Omits the nodePort field on the logstash headless service.

This fixes the error spec.ports[1].nodePort: Forbidden: may not be used when type is 'ClusterIP'

Applicable issues

Fixes:

Additional information

I didn't see a consistent way of expanding the service.spec.ports for headless services across bitnami charts, so I modelled this after the fluentd headless service.

The field service.spec.ports.name is an optional field (when only 1 port is used), so I opted to use service.spec.port.port instead (a required field). I don't love the nested omit, and happy to change the PR to "expand" the fields instead if you prefer.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the triage Triage is needed label Aug 16, 2023
@bitnami-bot bitnami-bot requested a review from carrodher August 16, 2023 20:15
@cbrwflo cbrwflo closed this Aug 16, 2023
@cbrwflo cbrwflo deleted the master branch August 16, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants