bitnami/logstash fix: support NodePorts in bitnami logstash chart #18474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Omits the
nodePort
field on the logstash headless service.This fixes the error
spec.ports[1].nodePort: Forbidden: may not be used when type is 'ClusterIP'
Applicable issues
Fixes:
Additional information
I didn't see a consistent way of expanding the
service.spec.ports
for headless services across bitnami charts, so I modelled this after the fluentd headless service.The field
service.spec.ports.name
is an optional field (when only 1 port is used), so I opted to useservice.spec.port.port
instead (a required field). I don't love the nestedomit
, and happy to change the PR to "expand" the fields instead if you prefer.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.