[bitnami/redis-cluster] support external host to cluster announcement preffered type #18028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jia-wei Yu <[email protected]>
Signed-off-by: Jia-wei Yu <[email protected]>
Signed-off-by: Jia-wei Yu <[email protected]>
|
@carrodher Is there any updates or reviews? |
aoterolorenzo
suggested changes
Aug 16, 2023
There was a problem hiding this comment.
Hi @yo-ga,
Sorry for all the delay with this, and thanks for the contribution!
I just left a minor comment, for the rest LGTM
Could you update the branch to merge? Thank you.
Signed-off-by: Jia-wei Yu <[email protected]>
Signed-off-by: Jia-wei Yu <[email protected]>
Signed-off-by: Jia-wei Yu <[email protected]>
Signed-off-by: Jia-wei Yu <[email protected]>
nascimento
pushed a commit
to nascimento/bitnami_charts
that referenced
this pull request
Aug 17, 2023
… preffered type (bitnami#18028) * feat: support external hostname Signed-off-by: Jia-wei Yu <[email protected]> * bump version Signed-off-by: Jia-wei Yu <[email protected]> * fix: redis environment var Signed-off-by: Jia-wei Yu <[email protected]> * chore: update chart version Signed-off-by: Jia-wei Yu <[email protected]> * chore: app version Signed-off-by: Jia-wei Yu <[email protected]> * chore: update version Signed-off-by: Jia-wei Yu <[email protected]> --------- Signed-off-by: Jia-wei Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support the external access host mode integrated with external load balancer in redis cluster, such as AWS LoadBalancer.
Benefits
Operator can set and use the load balancer hostname directly with redis cluster mode.
Possible drawbacks
NA
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm