[bitnami/rabbitmq] Revert rabbitmq probes #11177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73966c6. Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
|
Please don't revert. I suggested using another API in a comment on my change. I can apply it tomorrow. |
|
Please accept #11180 instead of this. Using ~30% CPU constantly just for liveness/readiness probes does not make any sense. |
|
I agree with you at 100% about the CPU usage, but I think is better to keep aligned with RabbitMQ documentation. This problem should be reported to the upstream project |
|
I doubt they ever meant for these liveness checks to be executed every 20 seconds. I'll report anyway. |
joancafom
approved these changes
Aug 10, 2022
deprecastor
pushed a commit
to deprecastor/charts
that referenced
this pull request
Aug 13, 2022
* Revert "[bitnami/rabbitmq] Fix high CPU usage while idle (bitnami#11117)" This reverts commit 73966c6. Signed-off-by: Fran Mulero <[email protected]> * Version bump Signed-off-by: Fran Mulero <[email protected]> Signed-off-by: Fran Mulero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR reverts changes in #11117 .Healthchecks implemented in that PR are deprecated
Benefits
Keep aligned with RabbitMQ Health Check recommendations
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm