Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correspond to commonmarker v1 #31

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

kawakamimoeki
Copy link
Contributor

@kawakamimoeki kawakamimoeki commented Mar 4, 2024

resolves #33

@kawakamimoeki kawakamimoeki force-pushed the correspond_to_commonmarker_v1 branch 4 times, most recently from 3c6a060 to 28ec024 Compare March 4, 2024 03:06
@kawakamimoeki kawakamimoeki self-assigned this Mar 4, 2024
@kawakamimoeki kawakamimoeki force-pushed the correspond_to_commonmarker_v1 branch 4 times, most recently from 4795de7 to 65cc295 Compare March 4, 2024 04:06
@kawakamimoeki kawakamimoeki reopened this May 6, 2024
@kawakamimoeki kawakamimoeki deleted the correspond_to_commonmarker_v1 branch May 6, 2024 22:55
@kawakamimoeki kawakamimoeki restored the correspond_to_commonmarker_v1 branch May 6, 2024 22:55
@kawakamimoeki kawakamimoeki reopened this May 6, 2024
@kawakamimoeki kawakamimoeki force-pushed the correspond_to_commonmarker_v1 branch from 41ece5f to 4bef1f3 Compare May 6, 2024 23:29
Comment on lines +18 to +20
tasklist: false,
shortcodes: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is true

@kawakamimoeki kawakamimoeki force-pushed the correspond_to_commonmarker_v1 branch from 4bef1f3 to e935903 Compare May 6, 2024 23:37
@kawakamimoeki kawakamimoeki marked this pull request as ready for review May 6, 2024 23:38

- name: Use ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache by default

@mugijiru mugijiru self-requested a review May 7, 2024 06:26
Copy link

@mugijiru mugijiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kawakamimoeki kawakamimoeki merged commit ea92cdd into master May 7, 2024
5 checks passed
@kawakamimoeki kawakamimoeki deleted the correspond_to_commonmarker_v1 branch May 7, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commonmarker v1
2 participants