Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an headerBlacklist option #216

Closed
maxday opened this issue Jul 26, 2019 · 2 comments
Closed

Add an headerBlacklist option #216

maxday opened this issue Jul 26, 2019 · 2 comments

Comments

@maxday
Copy link
Contributor

maxday commented Jul 26, 2019

Hello,

It could be great to have an headerBlacklist option.
This could be an array of headers name to omit from logs.

I know that this can be achievable using the requestFilter but I think that having a specific option will help.

Use case : don't log cookies, authorization bearer tokens etc.

I will prepare a PR for this change

What do you think ?
maxday added a commit to maxday/express-winston that referenced this issue Jul 26, 2019
@maxday
bithavoc#216 add headerBlacklist option
2cc574d
maxday added a commit to maxday/express-winston that referenced this issue Jul 26, 2019
@maxday
bithavoc#216 add headerBlacklist option
d415cea
maxday added a commit to maxday/express-winston that referenced this issue Jul 26, 2019
@maxday
bithavoc#216 add headerBlacklist option
f5d9fbd
@alokrajiv
Copy link
Contributor

hi @maxday @bithavoc , think this can be closed now. Since the PR #217 was merged?

@bithavoc bithavoc closed this as completed Oct 9, 2019
@bithavoc
Copy link
Owner

bithavoc commented Oct 9, 2019

Released as [email protected]. Please notice, there are breaking changes migrating from 3.x to 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bithavoc @maxday @alokrajiv