-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v-9.2.1 (#9614) #9625
Release v-9.2.1 (#9614) #9625
Conversation
WalkthroughThe pull request represents a comprehensive version update from Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js (1)
1-1
: Remove or maintain commented-out code carefully.You've updated the version comment to 9.2.1, which looks good. However, the large blocks of core service worker logic are now commented out. If you no longer need this logic, removing the commented-out sections entirely can help keep the codebase clean. Alternatively, if you plan to re-enable these features soon, consider adding a clear note or a feature flag mechanism.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
src/Besql/Bit.Besql/wwwroot/bit-besql.js
(1 hunks)src/Bit.Build.props
(1 hunks)src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
(1 hunks)src/BlazorUI/Demo/Directory.Build.props
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.ts
(1 hunks)src/Butil/Bit.Butil/Scripts/butil.ts
(1 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
(2 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props
(2 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
(1 hunks)src/Websites/Careers/src/Directory.Build.props
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
(1 hunks)src/Websites/Platform/src/Directory.Build.props
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
(1 hunks)src/Websites/Sales/src/Directory.Build.props
(1 hunks)
✅ Files skipped from review due to trivial changes (24)
- src/Websites/Platform/src/Directory.Build.props
- src/Websites/Careers/src/Directory.Build.props
- src/Websites/Sales/src/Directory.Build.props
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
- src/Butil/Bit.Butil/Scripts/butil.ts
- src/BlazorUI/Demo/Directory.Build.props
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
- src/Bup/Bit.Bup/Scripts/bit-bup.ts
- src/Bswup/FullDemo/Client/wwwroot/service-worker.js
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
- src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
- src/Besql/Bit.Besql/wwwroot/bit-besql.js
- src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
- src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
- src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
- src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
- src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj
🔇 Additional comments (21)
src/Bit.Build.props (1)
30-30
: Version update confirmation.Updating
<ReleaseVersion>
from9.2.1-pre-02
to9.2.1
is consistent with moving to a stable release. Looks good!src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)
41-41
: Updated installation command to stable version.Good job changing from
Bit.Boilerplate::9.2.1-pre-02
toBit.Boilerplate::9.2.1
. This ensures users install the stable template.src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (2)
4-11
: Stable version upgrade for multiple packages.These updates from
9.2.1-pre-02
to9.2.1
acrossBit.*
packages are properly aligned with the stable release. Nice work!
49-49
: Consistent version across offline database references.Upgrading
Bit.Besql
to9.2.1
is appropriate. The versions remain consistent with the rest of the codebase.src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2)
52-52
: Confirm offline DB dependency is correctly updated
UpdatingBit.Besql
to9.2.1
matches the rest of the stable version upgrades. Everything appears consistent.
4-11
: Transition to stable versions looks good
All previously pre-release references (9.2.1-pre-02
) were changed to stable9.2.1
. This aligns with the declared objective of finalizing the release.To ensure no references to
-pre
remain in the solution, run the following script:✅ Verification successful
Version transition verified - all references are using stable version
After checking all
.props
and.csproj
files in the codebase, I can confirm that all package references are consistently using the stable version9.2.1
without any pre-release suffixes. No instances of9.2.1-pre
or9.2.1-pre-02
were found, indicating a complete transition to the stable release version.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Searches the entire codebase for any leftover references to "9.2.1-pre" or "9.2.1-pre-02" rg '9.2.1-pre'Length of output: 14
Script:
#!/bin/bash # Let's search for any version references in props files and csproj files fd '\.(props|csproj)$' --exec rg -i '9\.2\.1.*'Length of output: 5142
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)
177-178
: Installation instruction updated to stable release
SwitchingBit.Boilerplate
from9.2.1-pre-02
to9.2.1
ensures the published documentation is aligned with the production-ready version.src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1)
9-13
: Analyzer and SourceGenerator references moved to stable
UpgradingBit.CodeAnalyzers
andBit.SourceGenerators
from pre-release to9.2.1
is appropriate for a final release.src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj (1)
9-13
: Consistent stable version for analyzers and source generators
Moving from9.2.1-pre-02
to9.2.1
aligns with the rest of the solution’s stable release references.src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1)
8-15
: LGTM! Version updates are consistent.The package version updates from pre-release to stable release are aligned with the PR objectives.
src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)
13-20
: LGTM! Version updates are consistent.The package version updates from pre-release to stable release are aligned with the PR objectives.
src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1)
13-20
: LGTM! Version updates are consistent.The package version updates from pre-release to stable release are aligned with the PR objectives.
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1)
8-15
: LGTM! Version updates are consistent.The package reference updates from pre-release to stable version (9.2.1-pre-02 -> 9.2.1) align with the release objectives.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)
27-36
: LGTM! Version updates are consistent.All package references have been correctly updated from pre-release to stable version (9.2.1-pre-02 -> 9.2.1), maintaining consistency across the project.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)
32-39
: LGTM! Version updates are consistent.The package reference updates from pre-release to stable version (9.2.1-pre-02 -> 9.2.1) align with the release objectives.
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1)
25-33
: LGTM! Package versions consistently updated to 9.2.1The package reference updates are consistent with the release objective, transitioning from pre-release to stable version.
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1)
25-33
: LGTM! Package versions aligned with other projectsThe package reference updates maintain consistency with other project files in the solution.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1)
25-34
: LGTM! Package versions consistently updated, including Platform-specific Bit.ButilThe package reference updates maintain consistency with other projects, while appropriately including the Platform-specific Bit.Butil package.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)
19-26
: Version updates look good!The package references have been correctly updated from pre-release to stable versions:
- Bit.CodeAnalyzers: 9.2.1
- Bit.SourceGenerators: 9.2.1
These updates align with the v9.2.1 release objective and maintain consistency with other stable dependencies.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (2)
88-96
: Version updates look good!The package references have been correctly updated from pre-release to stable versions:
- Bit.CodeAnalyzers: 9.2.1
- Bit.SourceGenerators: 9.2.1
These updates align with the v9.2.1 release objective and maintain consistency with other stable dependencies.
Line range hint
97-97
: Verify impact of removing launchSettings.jsonThe removal of
launchSettings.json
from Content might affect development environment configurations. Please ensure this removal is intentional and won't impact local development workflows.Run this script to check if the file still exists and is tracked by git:
✅ Verification successful
launchSettings.json
exists and is properly configuredThe file
launchSettings.json
still exists, is tracked by git, and contains valid configuration for Windows Machine debugging profile. The removal from Content in the .csproj file appears to be intentional as the file is still maintained in the repository with proper settings.Key observations:
- File exists at the correct location and is tracked by git
- Contains valid JSON configuration for MSIX package debugging
- The profile includes necessary settings for Windows Machine debugging
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if launchSettings.json exists and is tracked FILE_PATH="src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Properties/launchSettings.json" if [ -f "$FILE_PATH" ]; then echo "File exists on disk" if git ls-files --error-unmatch "$FILE_PATH" > /dev/null 2>&1; then echo "File is tracked by git" echo "Content:" cat "$FILE_PATH" else echo "File exists but is not tracked by git" fi else echo "File does not exist" fiLength of output: 656
closes #9614
Summary by CodeRabbit
Release
9.2.1-pre-02
to9.2.1
across multiple components and projectsPackage Updates
Scope