Prerelease v-9.1.0-pre-12 (#9466) #9467
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request introduces a series of updates across multiple project files and workflows, primarily focused on version increments to Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
.github/workflows/blazorui.demo.cd.yml (1)
121-126: Improve path handling in certificate extractionWhile the certificate extraction is secure, the path handling can be improved.
Consider this improvement:
- fileDir: '.\src\' - fileName: 'AssemblyOriginatorKeyFile.snk' + fileDir: './src' + fileName: 'AssemblyOriginatorKeyFile.snk'This ensures consistent path separators across platforms.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 124-124: wrong indentation: expected 8 but found 10
(indentation)
.github/workflows/admin-sample.cd.yml (1)
270-275: Fix YAML indentationThe indentation is inconsistent with the rest of the file (10 spaces instead of 8).
Apply this fix:
uses: timheuer/[email protected] with: - fileDir: '.\AdminPanel\src\' - fileName: 'AssemblyOriginatorKeyFile.snk' - encodedString: ${{ secrets.STRONG_SIGN_CERTIFICATE_BASE64 }} + fileDir: '.\AdminPanel\src\' + fileName: 'AssemblyOriginatorKeyFile.snk' + encodedString: ${{ secrets.STRONG_SIGN_CERTIFICATE_BASE64 }}🧰 Tools
🪛 yamllint (1.35.1)
[warning] 273-273: wrong indentation: expected 8 but found 10
(indentation)
src/BlazorUI/Bit.BlazorUI.Icons/Bit.BlazorUI.Icons.csproj (1)
Line range hint
27-39: Consider optimizing the SCSS build process.The current SCSS build setup is functional but could be enhanced:
- Consider caching npm packages in CI/CD
- Add error handling for missing node/npm
- Consider using a lock file for deterministic builds
Here's a suggested enhancement:
<Target Name="InstallNodejsDependencies" Inputs="package.json" Outputs="node_modules\.package-lock.json"> + <PropertyGroup> + <NodeInstalled>$([System.IO.File]::Exists('$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::Windows)) ? "where node" : "which node")'))</NodeInstalled> + </PropertyGroup> + <Error Condition="'$(NodeInstalled)' == 'false'" Text="Node.js is required to build the SCSS files. Please install Node.js and try again." /> <Exec Command="npm install" StandardOutputImportance="high" StandardErrorImportance="high" /> + <Exec Command="npm shrinkwrap" StandardOutputImportance="high" StandardErrorImportance="high" /> </Target>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (55)
.github/workflows/admin-sample.cd.yml(1 hunks).github/workflows/blazorui.demo.cd.yml(1 hunks).github/workflows/todo-sample.cd.yml(1 hunks)src/Besql/Bit.Besql/Bit.Besql.csproj(0 hunks)src/Besql/Bit.Besql/wwwroot/bit-besql.js(1 hunks)src/Bit.Build.props(2 hunks)src/BlazorUI/Bit.BlazorUI.Assets/Bit.BlazorUI.Assets.csproj(0 hunks)src/BlazorUI/Bit.BlazorUI.Extras/Bit.BlazorUI.Extras.csproj(0 hunks)src/BlazorUI/Bit.BlazorUI.Icons/Bit.BlazorUI.Icons.csproj(1 hunks)src/BlazorUI/Bit.BlazorUI/Bit.BlazorUI.csproj(0 hunks)src/BlazorUI/Bit.BlazorUI/Scripts/general.ts(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj(1 hunks)src/BlazorUI/Demo/Directory.Build.props(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js(1 hunks)src/Bswup/Bit.Bswup/Bit.Bswup.csproj(0 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.js(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js(1 hunks)src/Bup/Bit.Bup/Bit.Bup.csproj(0 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.ts(1 hunks)src/Butil/Bit.Butil/Bit.Butil.csproj(0 hunks)src/Butil/Bit.Butil/Scripts/butil.ts(1 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj(2 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate.ProjectTemplate.csproj(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props(2 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj(1 hunks)src/Websites/Careers/src/Directory.Build.props(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj(1 hunks)src/Websites/Platform/src/Directory.Build.props(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj(1 hunks)src/Websites/Sales/src/Directory.Build.props(1 hunks)
💤 Files with no reviewable changes (7)
- src/Butil/Bit.Butil/Bit.Butil.csproj
- src/BlazorUI/Bit.BlazorUI.Assets/Bit.BlazorUI.Assets.csproj
- src/Bswup/Bit.Bswup/Bit.Bswup.csproj
- src/BlazorUI/Bit.BlazorUI.Extras/Bit.BlazorUI.Extras.csproj
- src/BlazorUI/Bit.BlazorUI/Bit.BlazorUI.csproj
- src/Besql/Bit.Besql/Bit.Besql.csproj
- src/Bup/Bit.Bup/Bit.Bup.csproj
✅ Files skipped from review due to trivial changes (32)
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
- src/Websites/Sales/src/Directory.Build.props
- src/Bswup/FullDemo/Client/wwwroot/service-worker.js
- src/Websites/Careers/src/Directory.Build.props
- src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
- src/Butil/Bit.Butil/Scripts/butil.ts
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
- src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
- src/Templates/Boilerplate/Bit.Boilerplate.ProjectTemplate.csproj
- src/BlazorUI/Demo/Directory.Build.props
- src/Websites/Platform/src/Directory.Build.props
- src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
- src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
- src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
- src/Bup/Bit.Bup/Scripts/bit-bup.ts
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
- src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
- src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
- src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor
- src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
- src/Besql/Bit.Besql/wwwroot/bit-besql.js
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/blazorui.demo.cd.yml
[warning] 124-124: wrong indentation: expected 8 but found 10
(indentation)
.github/workflows/admin-sample.cd.yml
[warning] 273-273: wrong indentation: expected 8 but found 10
(indentation)
.github/workflows/todo-sample.cd.yml
[warning] 172-172: wrong indentation: expected 8 but found 10
(indentation)
🪛 actionlint (1.7.4)
.github/workflows/admin-sample.cd.yml
267-267: shellcheck reported issue in this script: SC1001:info:1:15: This \s will be a regular 's' in this context
(shellcheck)
267-267: shellcheck reported issue in this script: SC1001:info:1:19: This \A will be a regular 'A' in this context
(shellcheck)
🔇 Additional comments (24)
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)
41-41: LGTM! Version update is consistent with the PR objectives.
The version update from 9.1.0-pre-11 to 9.1.0-pre-12 aligns with the prerelease version bump described in the PR.
Let's verify version consistency across other template/package references:
✅ Verification successful
Version consistency verified across all references
All package references, template versions, and installation commands consistently use version 9.1.0-pre-12 throughout the codebase, including:
- Build properties in
src/Bit.Build.props - Template files in
src/Templates/ - Package references in all project files
- Installation commands and UI text in
Templates03GettingStartedPage.razor
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent version references
# Expected: All references should be 9.1.0-pre-12
# Search for version references in project files and templates
rg -g "*.{csproj,props,targets,cs,razor}" "9\.1\.0-pre-1[0-9]"
Length of output: 12126
src/Bit.Build.props (3)
29-32: LGTM: Version updates are consistent
The version properties are properly updated and maintain consistency across different version-related properties.
50-59: LGTM: Package content configuration
The ItemGroup properly includes LICENSE and README files in the package using correct path resolution.
44-48: Verify the presence of AssemblyOriginatorKeyFile.snk
The assembly signing configuration looks correct, but we should verify the key file's presence in the repository.
✅ Verification successful
Strong name key file is present in the repository
The AssemblyOriginatorKeyFile.snk exists in both the main src directory and the templates directory, confirming that the assembly signing configuration is properly supported by the presence of the required key file.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the strong name key file exists in the repository
fd AssemblyOriginatorKeyFile.snk
Length of output: 144
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (2)
1-1: LGTM: Template version is consistent
The template version comment correctly reflects the new version 9.1.0-pre-12.
86-89: Assembly signing configuration matches main build props
The signing configuration is consistent with the main build properties file.
.github/workflows/blazorui.demo.cd.yml (1)
117-120: LGTM: Secure handling of existing key file
The step properly ensures no existing key file remains before extraction.
.github/workflows/todo-sample.cd.yml (2)
165-168: Similar issue: Fix deletion command for Windows environment
This file has the same issue as in admin-sample.cd.yml where Windows-style commands are used in a non-Windows environment.
169-174: Similar issue: Fix YAML indentation
This file has the same indentation inconsistency as in admin-sample.cd.yml.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 172-172: wrong indentation: expected 8 but found 10
(indentation)
src/BlazorUI/Bit.BlazorUI.Icons/Bit.BlazorUI.Icons.csproj (2)
12-12: LGTM! Minor whitespace adjustment.
The indentation change maintains consistency with the project style.
Line range hint 1-46: Verify the impact of removed assembly signing.
The removal of assembly signing properties (as indicated in the summary) could affect security and deployment. Please ensure:
- This change aligns with the team's security requirements
- Dependent projects are updated accordingly
- Deployment pipelines are adjusted if they verify strong naming
✅ Verification successful
Assembly signing is still required and configured globally
The verification reveals that assembly signing is configured at the solution level through Bit.Build.props, which is imported by this project. The removal of signing properties from the individual project file is correct because:
- Assembly signing is enabled globally via
Bit.Build.propswith<SignAssembly>True</SignAssembly> - The key file path is configured centrally using
AssemblyOriginatorKeyFile.snk - The key files are present at the expected locations
No action is needed as the assembly will still be signed through the inherited global configuration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for other projects that might still expect strong naming
# Search for assembly signing references in other project files
echo "Checking for other projects with assembly signing..."
rg -l "SignAssembly|AssemblyOriginatorKeyFile" --type csproj
# Check for strong name verification in CI/CD workflows
echo "Checking for strong name verification in workflows..."
fd -e yml -e yaml . .github/workflows/ -x rg -l "sn -vf|StrongNameVerification"
Length of output: 407
Script:
#!/bin/bash
# Let's try a different approach to find assembly signing references
# First, let's find all .csproj files
echo "Finding .csproj files with signing related properties..."
fd -e csproj -x grep -l "SignAssembly\|AssemblyOriginatorKeyFile"
# Check for .snk files which are typically strong-name key files
echo "Checking for .snk key files..."
fd -e snk
# Look for signing related properties in Directory.Build.props if it exists
echo "Checking Directory.Build.props for signing configuration..."
fd "Directory.Build.props" -x grep -l "SignAssembly\|AssemblyOriginatorKeyFile"
# Check Bit.Build.props since it's imported in the project
echo "Checking Bit.Build.props for signing configuration..."
fd "Bit.Build.props" -x grep -A 2 "SignAssembly\|AssemblyOriginatorKeyFile"
Length of output: 1202
src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)
13-20: LGTM: Package version updates are consistent
The updates to Bit.CodeAnalyzers and Bit.SourceGenerators (9.1.0-pre-11 → 9.1.0-pre-12) align with the prerelease version bump. Both packages are correctly configured as build-time dependencies.
src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)
13-20: LGTM: Consistent with Sales.Server project
Package updates mirror those in the Sales.Server project, maintaining version consistency across website projects.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)
27-36: LGTM: Package versions aligned with prerelease
All package updates (9.1.0-pre-11 → 9.1.0-pre-12) are consistent with the prerelease version bump:
- Runtime dependency:
Bit.Bswup - Build-time dependencies:
Bit.CodeAnalyzers,Bit.SourceGenerators
Let's verify the changelog for breaking changes in Bit.Bswup:
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)
32-38: LGTM: Package version updates for development tools
The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators are consistent with the prerelease version bump. These are development-time dependencies that won't affect runtime behavior.
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1)
25-35: LGTM: Consistent package version updates
All Bit packages are consistently updated to version 9.1.0-pre-12. The updates include both runtime packages (BlazorUI, Icons, Assets) and development tools (CodeAnalyzers, SourceGenerators).
Let's verify that all Bit package references across the solution are updated to the same version:
✅ Verification successful
✅ Package versions are consistent across the solution
All Bit package references that specify a version are consistently using version 9.1.0-pre-12. Some package references appear without version numbers, but these are likely inherited from a central version management (e.g., Directory.Packages.props), which is a valid .NET practice.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent Bit package versions
# Expected: All Bit packages should be at version 9.1.0-pre-12
echo "Checking for inconsistent Bit package versions..."
rg -U 'PackageReference Include="Bit\.[^"]*" Version="[^"]*"' -g '*.csproj' | grep -v '9.1.0-pre-12'
Length of output: 209
Script:
#!/bin/bash
# Let's try a different approach to find all Bit package references
# First, find all csproj files
echo "All Bit package references in csproj files:"
fd -e csproj -x cat {} | grep -A1 'PackageReference Include="Bit\.'
Length of output: 6338
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (2)
25-35: LGTM: Package version updates match other projects
The package updates are consistent with the changes in other projects, maintaining version alignment across the solution.
Line range hint 21-22: Verify the configuration loading mechanism
The appsettings.json file has been changed from a content file to an embedded resource. This change affects how configuration is loaded at runtime.
Let's verify this change is consistent across all client projects and that the configuration loading code handles embedded resources:
✅ Verification successful
Configuration loading mechanism is consistent across client projects
The verification confirms:
- All client projects consistently handle
appsettings.jsonas an embedded resource - Each project has the corresponding configuration loading code using
GetManifestResourceStream - The change aligns with the existing pattern across the codebase
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check configuration handling across client projects
# Part 1: Check if all client projects use the same approach for appsettings.json
echo "Checking appsettings.json handling in client projects..."
rg -U '<(Content|EmbeddedResource) .*appsettings\.json' -g '*.csproj'
# Part 2: Check if configuration loading code handles embedded resources
echo "Checking configuration loading code..."
rg -U 'GetManifestResourceStream.*appsettings\.json' -g '*.cs'
Length of output: 3291
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (2)
19-26: LGTM: Package versions aligned with prerelease
The package versions for Bit.CodeAnalyzers and Bit.SourceGenerators have been consistently updated to 9.1.0-pre-12.
Line range hint 13-15: Verify configuration loading with EmbeddedResource
The appsettings.json has been changed from Content to EmbeddedResource. Ensure the application correctly loads the configuration at runtime.
✅ Verification successful
Let me analyze the search results to verify the configuration loading concern.
The first search showed how other projects handle embedded configurations, and now I want to verify if this specific project has similar configuration loading setup and startup files. This will help determine if the configuration change is properly handled.
I found the configuration extension file but need to verify its content and any other references to appsettings.json to ensure the configuration is properly handled after changing to EmbeddedResource.
Configuration loading is properly set up for embedded resource
The project already uses GetManifestResourceStream to load the configuration file, which is the correct approach for embedded resources. The IConfigurationBuilderExtensions.cs shows that the configuration is loaded using assembly.GetManifestResourceStream("Bit.BlazorUI.Demo.Client.Core.appsettings.json"), making it compatible with the EmbeddedResource build action.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the code properly handles embedded resource configuration
rg -A 5 "IConfiguration|AddJsonFile|GetManifestResourceStream.*appsettings\.json"
Length of output: 48698
Script:
#!/bin/bash
# Check if the project has configuration loading setup
rg -l "AddClientConfigurations|GetManifestResourceStream" src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/
# Check for Program.cs or similar startup files
fd -t f "Program.cs|Startup.cs" src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/
Length of output: 306
Script:
#!/bin/bash
# Check the content of IConfigurationBuilderExtensions.cs to verify configuration loading
cat src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Extensions/IConfigurationBuilderExtensions.cs
# Check if there are any references to appsettings.json in the project
rg -g "!*.{csproj}" "appsettings\.json" src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/
Length of output: 837
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (2)
25-37: LGTM: Consistent package version updates
All Bit.* packages have been consistently updated to version 9.1.0-pre-12, maintaining version alignment across the project.
Line range hint 19-22: Configuration changes aligned with core project
The changes to appsettings.json and compilerconfig.json are consistent with the changes in the core project.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (2)
88-96: LGTM: Package versions aligned with other projects
The package versions for Bit.CodeAnalyzers and Bit.SourceGenerators have been consistently updated to 9.1.0-pre-12, maintaining alignment with other projects.
Line range hint 97-97: Verify impact of removed launch settings
The removal of launchSettings.json might affect debug configurations. Ensure this doesn't impact local development workflows.
Closes #9466
Summary by CodeRabbit
New Features
9.1.0-pre-12, enhancing functionality and potentially introducing new features.appsettings.jsonas an embedded resource in various projects.Bug Fixes
Documentation
Chores
LICENSEandREADME.mdfiles in several projects to streamline the build process.