Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease v-9.1.0-pre-05 (#9363) #9368

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

msynk
Copy link
Member

@msynk msynk commented Dec 1, 2024

closes #9363

Summary by CodeRabbit

Release Notes for Version 9.1.0-pre-05

  • New Features

    • Updated version numbers for multiple packages to 9.1.0-pre-05, enhancing stability and performance.
    • Improved handling of service worker scripts for better asset management.
  • Bug Fixes

    • Resolved issues related to package references and project file configurations.
  • Documentation

    • Updated installation instructions for the Bit Boilerplate project template to reflect the new version.

These updates ensure a smoother user experience with the latest features and fixes.

@msynk msynk requested a review from ysmoradi December 1, 2024 19:52
Copy link

coderabbitai bot commented Dec 1, 2024

Walkthrough

The pull request introduces a series of updates across various project files, primarily focusing on version increments from 9.1.0-pre-04 to 9.1.0-pre-05. This includes updates to JavaScript files, project files, and service workers, reflecting changes in package references and versioning details. The modifications do not alter the existing logic or functionality of the components, maintaining the overall structure while ensuring that all references are aligned with the new pre-release version.

Changes

File Path Change Summary
src/Besql/Bit.Besql/wwwroot/bit-besql.js Updated BitBesql.version from '9.1.0-pre-04' to '9.1.0-pre-05'.
src/Bit.Build.props Updated <PackageReleaseNotes> and <PackageVersion> to reflect -pre-05.
src/BlazorUI/Bit.BlazorUI/Scripts/general.ts Updated BitBlazorUI.version from '9.1.0-pre-04' to '9.1.0-pre-05' and added event listeners for scroll and resize.
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj Updated Bit.CodeAnalyzers and Bit.SourceGenerators versions to 9.1.0-pre-05.
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj Updated package references for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.0-pre-05.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj Updated package references for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.0-pre-05.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj Updated package references for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.0-pre-05 and removed launchSettings.json.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj Updated package references for Bit.Bswup, Bit.CodeAnalyzers, and Bit.SourceGenerators to 9.1.0-pre-05.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js Updated version comment from 9.1.0-pre-04 to 9.1.0-pre-05.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj Updated Bit.CodeAnalyzers and Bit.SourceGenerators versions to 9.1.0-pre-05.
src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js Updated version comment from 9.1.0-pre-04 to 9.1.0-pre-05.
src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js Updated version comment from 9.1.0-pre-04 to 9.1.0-pre-05 and commented out significant logic.
src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js Updated version comment and modified asset exclusion and external asset version.
src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts Updated version from '9.1.0-pre-04' to '9.1.0-pre-05'.
src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts Updated version from '9.1.0-pre-04' to '9.1.0-pre-05'.
src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts Updated version from '9.1.0-pre-04' to '9.1.0-pre-05'.
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj Updated package references for Bit.BlazorUI, Bit.CodeAnalyzers, and Bit.SourceGenerators to 9.1.0-pre-05.
src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj Updated Bit.CodeAnalyzers and Bit.SourceGenerators versions to 9.1.0-pre-05.
src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj Updated Bit.CodeAnalyzers and Bit.SourceGenerators versions to 9.1.0-pre-05.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj Updated package references for Bit.Butil, Bit.BlazorUI, Bit.CodeAnalyzers, and Bit.SourceGenerators to 9.1.0-pre-05.
src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj Updated Bit.CodeAnalyzers and Bit.SourceGenerators versions to 9.1.0-pre-05.
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj Updated package references for Bit.BlazorUI, Bit.CodeAnalyzers, and Bit.SourceGenerators to 9.1.0-pre-05.
src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj Updated Bit.CodeAnalyzers and Bit.SourceGenerators versions to 9.1.0-pre-05.

Assessment against linked issues

Objective Addressed Explanation
Prerelease v-9.1.0-pre-05

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js (1)

Line range hint 39-102: Consider cleaning up commented code

A significant portion of the service worker implementation is commented out. This could indicate:

  1. Incomplete migration
  2. Technical debt
  3. Potential security implications of disabled functionality

Please either:

  • Remove the commented code if it's no longer needed
  • Implement the functionality if it's required
  • Add a comment explaining why this code is preserved
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fe0fa81 and b834176.

📒 Files selected for processing (43)
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js (1 hunks)
  • src/Bit.Build.props (1 hunks)
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1 hunks)
  • src/BlazorUI/Demo/Directory.Build.props (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts (1 hunks)
  • src/Butil/Bit.Butil/Scripts/butil.ts (1 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj (2 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (2 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj (1 hunks)
  • src/Websites/Careers/src/Directory.Build.props (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1 hunks)
  • src/Websites/Platform/src/Directory.Build.props (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1 hunks)
  • src/Websites/Sales/src/Directory.Build.props (1 hunks)
✅ Files skipped from review due to trivial changes (29)
  • src/Websites/Platform/src/Directory.Build.props
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
  • src/Butil/Bit.Butil/Scripts/butil.ts
  • src/Websites/Careers/src/Directory.Build.props
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
  • src/Websites/Sales/src/Directory.Build.props
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
  • src/BlazorUI/Demo/Directory.Build.props
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
  • src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
  • src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
  • src/Bit.Build.props
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
  • src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
🔇 Additional comments (21)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (2)

88-96: LGTM: Package version updates align with prerelease.

The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.0-pre-05 are consistent with the prerelease objectives.


Line range hint 97-97: Verify the impact of removing launchSettings.json

The removal of launchSettings.json from Content items should be verified to ensure it won't impact local development.

✅ Verification successful

The removal of launchSettings.json from Content items is a consistent pattern for MAUI projects

The verification shows that:

  • The launchSettings.json file still exists at src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Properties/launchSettings.json
  • Content removal of launchSettings.json is a deliberate pattern seen in MAUI projects (found in both Bit.BlazorUI.Demo.Client.Maui and Bit.Butil.Demo.Maui)
  • Other non-MAUI projects retain their launchSettings.json files without removal
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the file still exists and if it's referenced in other files
echo "Checking if launchSettings.json still exists:"
fd "launchSettings.json" --type f

echo -e "\nChecking for other references to launchSettings.json in project files:"
rg -g "*.csproj" "launchSettings.json"

echo -e "\nChecking if this is a pattern across other MAUI projects:"
fd -e csproj . | xargs rg "Remove.*launchSettings.json"

Length of output: 2666

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)

32-38: LGTM! Package version updates are consistent.

The version updates for both Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.0-pre-05 align with the prerelease objectives.

Let's verify version consistency across other project files:

✅ Verification successful

Package versions are consistent across the solution

After checking all project files in the repository, I can confirm that all references to Bit.CodeAnalyzers and Bit.SourceGenerators consistently use version 9.1.0-pre-05. The version updates are properly synchronized across the entire solution.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any inconsistent package versions across the solution

# Search for Bit.CodeAnalyzers and Bit.SourceGenerators package references
echo "Checking package versions across all project files..."
rg -A 1 'Include="Bit\.(CodeAnalyzers|SourceGenerators)"' --type csproj

Length of output: 221


Script:

#!/bin/bash
# Let's try a different approach using fd to find .csproj files first
# Then use grep to search for the package references

# Find all .csproj files and search for package references
fd -e csproj -x grep -A 1 'Include="Bit\.(CodeAnalyzers|SourceGenerators)"' {}

Length of output: 82


Script:

#!/bin/bash
# Let's try a simpler approach first to find all .csproj files
echo "Finding all .csproj files:"
fd -e csproj

echo -e "\nNow checking content of these files for package references:"
fd -e csproj -x cat {} | grep -A 2 'PackageReference.*Bit\.'

Length of output: 14603

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (4)

Line range hint 4-48: Version updates are consistent with prerelease objectives

All Bit package versions have been consistently updated to 9.1.0-pre-05, aligning with the PR objectives for the prerelease. The changes maintain version consistency across core packages, build tools, and conditional packages.


4-8: Verify package interdependencies for core Bit packages

The version updates for core Bit packages are consistent. However, let's verify there are no breaking changes in package interdependencies.

✅ Verification successful

Package interdependencies are consistent across the codebase

Based on the analysis of project files, the package references show consistent version updates (9.1.0-pre-05) across all Bit packages. The interdependencies follow a clear pattern:

  • Client projects (like Bit.Websites.Platform.Client) appropriately bundle UI-related packages (BlazorUI, BlazorUI.Icons, BlazorUI.Assets) together
  • Core packages like Bit.Butil are referenced where needed
  • Development tools (CodeAnalyzers, SourceGenerators) maintain consistent versions
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check package references between core Bit packages
# Look for direct references between these packages in .csproj files

echo "Checking package references in project files..."
fd -e csproj -x grep -l "Include=\"Bit\." {} \; | while read -r proj; do
    echo "=== $proj ==="
    grep -A 1 "Include=\"Bit\." "$proj"
done

Length of output: 16230


9-11: Verify build stability with updated tool versions

The build tools (Bswup, CodeAnalyzers, SourceGenerators) have been updated to match the prerelease version. These changes might affect the build process.

✅ Verification successful

Let me gather more information about the build configuration and dependencies to better assess the impact of these tool updates.


Based on the analysis of the build configuration files and package references, I can now provide a final response:

Build tool updates are consistent with project dependencies

The updated build tools (Bswup, CodeAnalyzers, SourceGenerators) to version 9.1.0-pre-05 align with other Bit platform packages used throughout the solution. Multiple projects are already referencing these tools at the same version, indicating a coordinated update across the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Look for any build-related TODO/HACK comments or warnings that might be affected

echo "Checking for build-related comments..."
rg -i "todo|hack|fixme|xxx" -g "*.props" -g "*.targets" -g "*.csproj"

echo "Checking for analyzer configuration files..."
fd -e editorconfig -e ruleset

Length of output: 289


Script:

#!/bin/bash
# Check for any existing package references and configurations
echo "Checking package references in props and project files..."
rg -g "*.props" -g "*.csproj" "PackageReference|PackageVersion.*Bit\."

echo "Checking build configurations..."
fd -e props -e targets | xargs cat

echo "Checking for any MSBuild imports..."
rg -g "*.props" -g "*.csproj" -g "*.targets" "Import.*Bit\."

Length of output: 88554


48-48: Verify offline database functionality with updated Besql version

The Bit.Besql package has been updated to match the prerelease version. Since this is a conditional package for offline database functionality, ensure all offline database features remain compatible.

✅ Verification successful

Let me gather more information about the Besql usage and offline database configurations.


Let me check the offline database implementation to verify compatibility.


Based on the analysis of the codebase, I can now provide the final response:

✅ Besql package update is compatible with existing offline database implementation

The update of Bit.Besql to version 9.1.0-pre-05 is safe as:

  • The offline database implementation in OfflineDbContext follows standard EF Core patterns
  • The AddBesqlDbContextFactory API signature remains unchanged
  • The existing configuration in IClientCoreServiceCollectionExtensions.cs is compatible with the updated version
  • The package is properly conditioned with the offlineDb feature flag
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for offline database related configurations and usages

echo "Checking for offline database configurations..."
rg -l "offlineDb" -g "*.cs" -g "*.csproj" -g "*.props"

echo "Checking for Besql usage patterns..."
ast-grep --pattern 'using Bit.Besql;'

Length of output: 1607


Script:

#!/bin/bash
# Check the content of relevant configuration files and usages

echo "Checking Directory.Packages8.props content..."
cat src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props

echo -e "\nChecking IClientCoreServiceCollectionExtensions.cs for Besql configuration..."
cat src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Extensions/IClientCoreServiceCollectionExtensions.cs

echo -e "\nChecking for Besql version references in other files..."
rg "Bit.Besql" -g "*.csproj" -g "*.props" -A 2 -B 2

Length of output: 25799


Script:

#!/bin/bash
# Check offline database implementation and configuration

echo "Checking OfflineDbContext implementation..."
cat src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Data/OfflineDbContext.cs

echo -e "\nChecking for Besql usage in the codebase..."
rg -l "Bit.Besql" -g "*.cs"

echo -e "\nChecking for breaking changes in Besql package..."
rg "AddBesqlDbContextFactory|UseBesql" -g "*.cs" -A 2 -B 2

Length of output: 6772

src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js (2)

1-1: Version update aligns with PR objective

The version update to 9.1.0-pre-05 is consistent with the prerelease version specified in the PR.


Line range hint 15-28: Verify external assets configuration

The external assets configuration includes critical files like blazor.web.js with version 9.0.0. Please ensure this version is compatible with the prerelease version 9.1.0-pre-05.

✅ Verification successful

Version compatibility verified - no issues found

The blazor.web.js version 9.0.0 in the service worker configuration is consistent with all ASP.NET Core Components packages used across the project. All related packages (Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, etc.) are using version 9.0.0, which is the stable release that should work correctly with prerelease packages like Bit.CodeAnalyzers version 9.1.0-pre-05.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for blazor.web.js version compatibility across the project
rg -g '*.csproj' "Microsoft.AspNetCore.Components.Web" -A 1

Length of output: 18370

src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)

13-20: Version updates are consistent with prerelease

The package reference updates for Bit.CodeAnalyzers and Bit.SourceGenerators to version 9.1.0-pre-05 align with the PR's prerelease version.

✅ Verification successful

Version consistency verified across all projects

The search results confirm that all projects consistently use version 9.1.0-pre-05 for both Bit.CodeAnalyzers and Bit.SourceGenerators packages. Let's verify the AspNetCore package versions to ensure compatibility:


Version consistency and compatibility confirmed

The package versions are properly aligned:

  • All Bit packages (Bit.CodeAnalyzers and Bit.SourceGenerators) are consistently at version 9.1.0-pre-05
  • All AspNetCore packages are at version 9.0.0, which is compatible with the Bit prerelease packages
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify version consistency across all project files
rg -g '*.csproj' "Bit\.(CodeAnalyzers|SourceGenerators)" -A 1

Length of output: 10291


Script:

#!/bin/bash
# Check AspNetCore package versions in the Careers.Server project
rg -g 'Bit.Websites.Careers.Server.csproj' "Microsoft\.AspNetCore\." -A 1

Length of output: 1088

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (2)

Line range hint 3-13: Verify WebAssembly configuration compatibility

The WebAssembly configuration includes important settings for time zone support, globalization, and PWA features. Please ensure these settings are compatible with the updated package versions.

✅ Verification successful

Based on the search results, I can now generate the final response since I have enough information to verify the WebAssembly configuration compatibility:

WebAssembly configuration is compatible with other projects

The configuration settings in the file are consistent with other Blazor WebAssembly projects in the codebase that use the same .NET 9.0 target framework. Specifically:

  • Time zone and globalization settings (BlazorEnableTimeZoneSupport, HybridGlobalization) are used similarly in other template projects like Boilerplate.Client.Web
  • PWA-related settings (ServiceWorkerAssetsManifest, BlazorCacheBootResources) match the configuration in other PWA-enabled projects like Bit.Bswup.Demo
  • Performance optimization settings (WasmStripILAfterAOT, BlazorWebAssemblyPreserveCollationData) align with other production configurations
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for similar WebAssembly configurations across the project
rg -g '*.csproj' "Sdk=\"Microsoft.NET.Sdk.BlazorWebAssembly\"" -A 15

Length of output: 24876


27-36: Package versions align with prerelease

The version updates for Bit.Bswup, Bit.CodeAnalyzers, and Bit.SourceGenerators to 9.1.0-pre-05 are consistent with the PR's prerelease version.

✅ Verification successful

Let me gather more information about the version consistency across all Bit packages.


Package versions are consistently aligned

All Bit packages across the solution are consistently using version 9.1.0-pre-05, including Bit.Bswup, Bit.CodeAnalyzers, Bit.SourceGenerators, Bit.BlazorUI, Bit.BlazorUI.Icons, Bit.BlazorUI.Assets, and Bit.Butil. The version updates in the BlazorUI Demo Client Web project align with the overall package versioning strategy.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify version consistency for Bit.Bswup across the project
rg -g '*.csproj' "Bit\.Bswup" -A 1

Length of output: 2247


Script:

#!/bin/bash
# Check versions of all Bit packages across the solution
rg -g '*.csproj' '<PackageReference Include="Bit\.' -A 1

Length of output: 14691

src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js (1)

Line range hint 8-15: Verify security implications of the Google Tag Manager script

The addition of the Google Tag Manager script to externalAssets should be reviewed for:

  • Proper CSP (Content Security Policy) headers
  • Data privacy implications
  • Performance impact on the service worker
src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (2)

25-35: Verify version consistency across the solution

The package version updates to 9.1.0-pre-05 look consistent for all Bit packages. However, let's verify there are no missed updates across the solution.

✅ Verification successful

Package versions are consistent across the solution

Based on the search results, all explicit version references to Bit packages are consistently set to 9.1.0-pre-05. No instances of pre-04 or any other versions were found. Some Bit package references without explicit versions exist, but these are likely controlled by central package management or other dependency mechanisms.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any remaining pre-04 versions
rg "9\.1\.0-pre-04" --type xml

# Check version consistency across all project files
rg "<PackageReference Include=\"Bit\." --type xml -A 1

Length of output: 88


Script:

#!/bin/bash
# Let's try a broader search for Bit package references
fd ".csproj$" --exec grep -A 1 "PackageReference.*Bit\." {} \;

# Also search for any version pattern that might match pre-04 or pre-05
fd ".csproj$" --exec grep -A 1 "Include=\"Bit\..*Version=\"[0-9]" {} \;

Length of output: 12115


Line range hint 19-23: Verify impact of resource type changes

The change of appsettings.json to EmbeddedResource and compilerconfig.json to None might affect:

  • Runtime configuration loading
  • Build process
  • Resource accessibility

Please ensure these changes are intentional and tested.

✅ Verification successful

Resource type changes are consistent with project patterns

The changes to resource types are appropriate based on the codebase analysis:

  • appsettings.json as EmbeddedResource: This is consistent with other client projects in the codebase, as evidenced by the presence of IConfigurationBuilderExtensions.cs files in multiple client projects that need to access embedded configuration.
  • compilerconfig.json as None: This is a common pattern for client-side projects that use this file for SCSS/CSS compilation configuration, and treating it as None is appropriate as it's a build-time configuration file.

The changes align with the project's architecture and similar patterns seen across other client projects in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for similar resource type patterns across other projects
rg -l "EmbeddedResource.*appsettings\.json" --type xml
rg -l "None.*compilerconfig\.json" --type xml

Length of output: 104


Script:

#!/bin/bash
# Let's try a broader search for these files and their usage patterns
rg "appsettings\.json" --type xml -A 2 -B 2
rg "compilerconfig\.json" --type xml -A 2 -B 2

# Also check if these files exist and their content structure
fd -e json -x file {}

Length of output: 4512


Script:

#!/bin/bash
# Let's try a simpler approach to find these files and their references
fd appsettings.json
fd compilerconfig.json

# Check for any Program.cs or Startup.cs files that might load these configurations
rg -l "appsettings" --type cs

Length of output: 3485

src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1)

25-35: LGTM! Consistent with other project updates

The package version updates and resource type changes are consistent with the changes made in Bit.Websites.Sales.Client.csproj, indicating a well-coordinated prerelease update.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)

19-26: LGTM! Package versions updated consistently

The package versions have been updated correctly to align with the prerelease version v-9.1.0-pre-05.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1)

25-37: LGTM! Package versions updated consistently

All Bit platform packages have been updated correctly to version 9.1.0-pre-05, maintaining version consistency across the project.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)

41-41: LGTM! Template version updated consistently

The Bit.Boilerplate template version in the installation command has been updated correctly to 9.1.0-pre-05.

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (1)

4-11: LGTM: Package versions consistently updated

The package versions have been consistently updated from 9.1.0-pre-04 to 9.1.0-pre-05 across all Bit packages, maintaining proper synchronization.

Also applies to: 48-48

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)

170-171: LGTM: Documentation correctly updated

The installation instructions have been properly updated to reflect the new version 9.1.0-pre-05, maintaining consistency with the package updates.

@msynk msynk merged commit 53db344 into bitfoundation:develop Dec 1, 2024
3 checks passed
@msynk msynk deleted the 9363-prerelease-v-9.1.0-pre-05 branch December 1, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerelease v-9.1.0-pre-05
2 participants