New checkbox to allow for connections via SSL #80
Conversation
|
Hey @Cinzya looks good |
|
Bumped version to 4.4.0 in |
src/v3/connection.ts
Outdated
| @@ -46,7 +46,9 @@ export function connect(self: OnTimeInstance, ontime: OntimeV3): void { | |||
| host.replace(pattern, '') | |||
There was a problem hiding this comment.
Hey @Cinzya I've tested you stuff in a full stack and it works great
but i then found that this replace dosn't work so if you put in https://ontime.dk into the Ontime server address field it would fail with Connection Failure WebSocket error: getaddrinfo ENOTFOUND https
would you have time to look at this?
It is not directly related to your PR but it would fit in ok
There was a problem hiding this comment.
Oh, I wasn't aware that this is an option.
Seems to be an easy fix, I should be able to take a look at it later today or in the next few days. No problem!
There was a problem hiding this comment.
found the issue and pushed a fix!
|
@cpvalente if you would give it a quick look, then it is ready for merging |
I am running ontime behind a proxy which only allows connections through SSL.
So I added another checkbox to the config, which is by default false, to check if SSL is prefered. In the connection phase, it will then either use
wsorwssdepending on the state of the checkbox, and eitherhttporhttpwhen fetching custom fields and all events.