Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Push] Handle subscription expiration #1131

Merged
merged 7 commits into from
Nov 17, 2024
Merged

[Push] Handle subscription expiration #1131

merged 7 commits into from
Nov 17, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Nov 17, 2024 •
edited
Loading

Purpose

WebDAV-Push subscription can expire, and this has to be handled by the client.

Short description

  • Request expiration after 3 days (MUST be supported).
  • Stores Expires header from the server as expiration date.
  • Make PushRegistrationWorker run regularly (daily), if there are push-capable collections.
  • Don't update push subscriptions that are still not about to expire.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 added the enhancement New feature or request label Nov 17, 2024
@rfc2822 rfc2822 self-assigned this Nov 17, 2024
@rfc2822 rfc2822 linked an issue Nov 17, 2024 that may be closed by this pull request
[Push] Handle expiration of subscription registrations #1015
Closed
2 tasks
@rfc2822 rfc2822 force-pushed the 1015-push-handle-expiration-of-subscription-registrations branch from 3086e03 to 29a03c9 Compare November 17, 2024 12:02
@rfc2822 rfc2822 marked this pull request as ready for review November 17, 2024 12:34
@rfc2822 rfc2822 force-pushed the 1015-push-handle-expiration-of-subscription-registrations branch from 48d02d3 to d9a1fc4 Compare November 17, 2024 12:46
@rfc2822 rfc2822 force-pushed the 1015-push-handle-expiration-of-subscription-registrations branch from d9a1fc4 to c9ab2fd Compare November 17, 2024 13:32
@rfc2822 rfc2822 requested review from sunkup and removed request for sunkup November 17, 2024 13:38
@rfc2822 rfc2822 merged commit 3a16b5c into main-ose Nov 17, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1015-push-handle-expiration-of-subscription-registrations branch November 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rfc2822 rfc2822

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Push] Handle expiration of subscription registrations
1 participant
@rfc2822