fix(slice): fix bug in slice that produces new line for empty input slice #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfield
requested changes
Oct 19, 2024
script_test.go
Outdated
| got, err := script.Slice([]string{"1", "2", "3"}).String() | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| tests := []struct { |
There was a problem hiding this comment.
It seems a shame to have a table test with just two cases, doesn't it? Especially as they're different cases, not two examples of the same behaviour.
Wouldn't you rather just structure this as two separate tests? That tends to make each test clearer, more focused, and easier to understand.
bitfield
reviewed
Oct 20, 2024
script.go
Outdated
| @@ -182,6 +182,9 @@ func Post(url string) *Pipe { | |||
|
|
|||
| // Slice creates a pipe containing each element of s, one per line. | |||
There was a problem hiding this comment.
Suggested change
| // Slice creates a pipe containing each element of s, one per line. | |
| // Slice creates a pipe containing each element of s, one per line. If s is | |
| // empty or nil, then the pipe is empty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #110 by handling an empty input into the
Slicefunction.Added a new unit test