-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LFU sketch using arm64 intrinsics #595
Draft
bitfaster
wants to merge
11
commits into
main
Choose a base branch
from
users/alexpeck/arm64
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+161
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfaster
changed the title
Implement Sketch using arm intrinsics
Implement Sketch using arm64 intrinsics
May 24, 2024
Windows on ARM results (virtual machine).
|
WIndows on ARM, .NET 8
|
bitfaster
commented
May 25, 2024
With VectorTableLookup
|
|
bitfaster
changed the title
Implement Sketch using arm64 intrinsics
Implement LFU sketch using arm64 intrinsics
May 25, 2024
bitfaster
commented
May 25, 2024
|
||
// Before: < 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, F > | ||
// After: < 0, 1, 2, 3, 8, 9, A, B, 4, 5, 6, 7, C, D, E, F > | ||
var min = AdvSimd.Arm64.VectorTableLookup(a.AsByte(), Vector128.Create(0x0B0A090803020100, 0xFFFFFFFFFFFFFFFF).AsByte()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On later versions of .NET VectorTableLookup can also take two or more 128 bit registers as input.
See this example:
dotnet/runtime#87126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below the *BlockAvx benchmark runs on the ARM64 intrinsics, FlatAVX is not implemented.
Mac M2
Repros on commit 7d7d023, but not newest.
Windows Cobalt 100 (VM)
Notes
To run benchmarks, start as .NET6+. Benchmarkdotnet fails to run .NET6+ benches from a .NET48 process. It may be starting under emulation on the test machine.