ci: re-enable android emulator tests #54
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,7 +85,7 @@ jobs: | |
| path: ./bazel-bin/examples/android/android_app.apk | ||
| gradle_tests: | ||
| # Requires a "larger runner", for nested virtualization support | ||
| runs-on: ubuntu-latest-8-cores | ||
| env: | ||
| SKIP_PROTO_GEN: 1 | ||
| if: needs.pre_check.outputs.should_run == 'true' | ||
|
|
@@ -97,16 +97,16 @@ jobs: | |
| # See https://github.blog/changelog/2023-02-23-hardware-accelerated-android-virtualization-on-actions-windows-and-linux-larger-hosted-runners/ | ||
| - name: Enable KVM group perms | ||
| run: | | ||
| echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules | ||
| sudo udevadm control --reload-rules | ||
| sudo udevadm trigger --name-match=kvm | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '17' | ||
| cache: gradle | ||
| - name: Set up Rust ARM target | ||
| run: rustup update && rustup target add aarch64-linux-android && rustup target add x86_64-linux-android | ||
| - name: AVD cache | ||
| uses: actions/cache@v4 | ||
|
|
@@ -121,13 +121,13 @@ jobs: | |
| timeout-minutes: 30 | ||
| uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 # [email protected] | ||
| with: | ||
| channel: stable | ||
|
There was a problem hiding this comment. This is the clue of the change There was a problem hiding this comment. dang I wonder why were using beta |
||
| force-avd-creation: false | ||
| api-level: 21 | ||
| target: default | ||
| ram-size: 2048M | ||
| arch: x86_64 | ||
| disk-size: 6144M | ||
| profile: Nexus 6 | ||
| disable-animations: true | ||
| emulator-options: -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
|
|
@@ -141,13 +141,13 @@ jobs: | |
| - name: Instrumentation Tests | ||
| uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 # [email protected] | ||
| with: | ||
| channel: stable | ||
| force-avd-creation: false | ||
| api-level: 21 | ||
| target: default | ||
| ram-size: 2048M | ||
| arch: x86_64 | ||
| disk-size: 6144M | ||
| profile: Nexus 6 | ||
| disable-animations: true | ||
| emulator-options: -no-snapshot-save -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
Augustyniak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
@@ -189,12 +189,12 @@ jobs: | |
| timeout-minutes: 30 | ||
| uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b # pin@v2 | ||
| with: | ||
| channel: stable | ||
| api-level: ${{ matrix.api-level }} | ||
| target: google_apis | ||
| ram-size: 2048M | ||
| arch: x86_64 | ||
| disk-size: 6144M | ||
| profile: Nexus 6 | ||
| emulator-options: -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
| script: echo "Generated AVD snapshot for caching." | ||
|
|
@@ -203,12 +203,12 @@ jobs: | |
| timeout-minutes: 15 | ||
| with: | ||
| force-avd-creation: false | ||
| channel: stable | ||
| api-level: ${{ matrix.api-level }} | ||
| target: google_apis | ||
| ram-size: 2048M | ||
| arch: x86_64 | ||
| disk-size: 6144M | ||
| profile: Nexus 6 | ||
| emulator-options: -no-snapshot-save -no-window -accel on -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
| script: ./ci/verify_android.sh | ||
|
|
@@ -226,6 +226,4 @@ jobs: | |
| with: | ||
| fetch-depth: 1 | ||
| - name: check result | ||
| run: ./ci/check_result.sh ${{ needs.pre_check.result }} && ./ci/check_result.sh ${{ needs.build_apk.result }} && ./ci/check_result.sh ${{ needs.verify_android_hello_world_per_version.result }} && ./ci/check_result.sh ${{ needs.gradle_tests.result }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really required to be a part of this PR but since it effectively doesn't work as we moved to
ubuntu-latestrecently I decided to clean it up (remove)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forgot why we removed using virtualization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to ubuntu-latest was fixing another issues that we had while trying to update to the latest version of the NDK https://github.com/bitdriftlabs/capture-sdk/pull/40/files#diff-fc26471d058677138d1caf923b0188a49eaf3437ba2f1cec8a6927ee0a1f0402R88.
ubuntu-latest-8-coresdidn't have the latest version of NDK available whileubuntu-latesthad it.Now that I am playing with it I cannot even make the
gradle_testsCI job work withubuntu-latestanymore so moving back to-8-coresvariant.