Add run_opts to SSHKit.run with default empty list #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow us to do things like setup a custom capture function for messages while still getting to use the higher level contexts abstraction.
pmeinhardt
reviewed
Jun 30, 2020
There was a problem hiding this comment.
Hey @carterbryden, thanks a lot! 🥳
It would be great if you could add a unit test for this addition to ensure it's working properly and it won't accidentally break in the future. 💚
Please let us know if you need any support or pointers. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow us to do things like setup a custom capture function for messages while still getting to use the higher level contexts abstraction.
Description
Added a 3rd arg to SSHKit.exe that defaults to an empty list for run options, to be used with SSHKit.SSH.run underneath.
Motivation and Context
This issue reply explained how to use the underlying functions, but I'd really like to be able to keep using the conexts abstraction. This should let me do both.
Types of changes
Checklist
Haven't updated docs or tests because I think the existing ones already cover this.
## mastersection).