Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete redundant extern declaration #871

Merged
merged 1 commit into from
Oct 12, 2021
Merged

delete redundant extern declaration #871

merged 1 commit into from
Oct 12, 2021

Conversation

jpreiss
Copy link
Contributor

@jpreiss jpreiss commented Oct 11, 2021

This extern declaration for trajectory memory used to be in the high level commander header, but was abstracted behind a read/write API in 73a4e93. The variable is defined in crtp_commander_high_level.c a few lines below, so an extern declaration visible only to crtp_commander_high_level.c is redundant.

jonasdn
jonasdn approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jonasdn jonasdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jonasdn jonasdn merged commit aa30c6a into bitcraze:master Oct 12, 2021
@knmcguire knmcguire added this to the next release milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasdn jonasdn jonasdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022.01
Development

Successfully merging this pull request may close these issues.
3 participants
@jpreiss @jonasdn @knmcguire