Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf_math: remove matrixcopy/vectorcopy in favor of memcpy() #868

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

whoenig
Copy link
Contributor

@whoenig whoenig commented Oct 10, 2021

  • memcpy() should be faster than an elementwise copy
  • memcpy() is easier to read in the code, as the definition is well
    known

@jonasdn
Copy link
Contributor

jonasdn commented Oct 12, 2021

Could you rebase this on master?

Something like:

$ git rebase origin master
$ git push -f IMRCLab cf_math_cleanup3

* memcpy() should be faster than an elementwise copy
* memcpy() is easier to read in the code, as the definition is well
  known
@whoenig
Copy link
Contributor Author

whoenig commented Oct 12, 2021

Could you rebase this on master?

Done!

@jonasdn jonasdn merged commit 648cead into bitcraze:master Oct 12, 2021
@knmcguire knmcguire added this to the next release milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants