-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-standard IMU orientation (mostly for Bolt) #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Testing is needed.
As for the testing, I did test the code with:
While I beleive this is enough evidence, always good if someone could reproduce the tests. |
@matejkarasek Could you try to resolve the merge conflict? The history is better preserved if you do it. |
Done! |
Thanks! I tested it simply by viewing the virtual horizon in the cfclient for different PHI, THETA, PSI values and it looked good. I think this functionality is a really good start which also highlights that we should make this easier to configure in the future. The functionality is also overlapping the pitch and roll trimming which I think should be replaced with a easy to configure Euler angle setup in the future. Well that is then, let's start with this step first :-) |
Great! I agree it would be nice to have this easily configurable, e.g. through some sort of persistent setting, and then it could indeed replace the roll/pitch trims... |
This PR enables to define non-standard orientation of the IMU on the airframe, e.g. when using the Crazyflie Bolt on unconventional aircrafts.
The user can specify the Euler angles of the IMU using the defines in the config file.