Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional transmit channel for raw lighthouse data #807

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

jdavidberger
Copy link
Contributor

This change allows one to set a parameter and start streaming off the raw light data. This is slightly different and in a more raw state than the port and channel which transmits angle data. It is also packed in such a way to allow two full frames of light data per packet, so in theory a single lighthouse will consume ~50p/s.

The transmit is non blocking, so if the bandwidth is there it works and if it isn't, it just moves on to the next without endangering the stability of on-board tracking. The computational overhead should also pretty insignificant at these data rates.

I have a branch in libsurvive that has the receiver logic for reference.

@knmcguire knmcguire requested a review from ataffanel July 8, 2021 08:05
@knmcguire
Copy link
Member

There are some checks that are failing so you might want to take a look at that.

On the first sight, this seems to be fine! But I also want @ataffanel to look at this, who will be back next week.

@ataffanel
Copy link
Member

Hi, Sorry for the delayed review, this looks great I am merging it, thanks!

Do you by any change have a simple python script showing how to use this new functionality that we could put in the python lib example folder?

@ataffanel ataffanel merged commit cbbbbde into bitcraze:master Jul 21, 2021
@jdavidberger
Copy link
Contributor Author

Not right not but possibly later. I need to merge the libsurvive in; and then potentially update the pysurvive bindings -- currently they are autogenerated and I think I need to update how that all works.

@knmcguire knmcguire added this to the next release milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants