vendor: Upgrade CMSIS from 4.5.0 to 5.7.0 #715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMSIS 4 is a legacy version and as @whoenig told me in #708 (comment):
The only difference I found in code between CMSIS 4 and 5 is that the latter offers two versions of
arm_bitreversal2
:https://github.com/ARM-software/CMSIS/blob/master/CMSIS/DSP_Lib/Source/TransformFunctions/arm_bitreversal2.S
https://github.com/ARM-software/CMSIS_5/blob/develop/CMSIS/DSP/Source/TransformFunctions/arm_bitreversal2.S
https://github.com/ARM-software/CMSIS_5/blob/develop/CMSIS/DSP/Source/TransformFunctions/arm_bitreversal2.c
The
Makefile
would automatically pick the C version when the target is solelyDSP_OBJ += arm_bitreversal2.o
: https://github.com/bitcraze/crazyflie-firmware/blob/master/tools/make/cmsis_dsp/obj.mk#L273. That’s whyCSFLAGS
is not required anymore. I removed__TARGET_FPU_VFP
like #709. I also removed the unused includes$(CRAZYFLIE_BASE)/src/utils/interface/clockCorrection
and$(CRAZYFLIE_BASE)/src
. Finally, I sorted the targets.With #713 and this, this repo. would be buildable with Clang.
I need reviews of this PR.
Thank you in advance.