Makefile: Error out on missing submodules #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasdn
force-pushed
the
jonasdn/error-submodules
branch
3 times, most recently
from
11bb4a7 to
76996f1
Compare
jonasdn
changed the title
jonasdn
force-pushed
the
jonasdn/error-submodules
branch
from
76996f1 to
b78cbed
Compare
If you, like me, fail to read the README.md properly you will get a bit
of a cryptic error when trying to build.
$ make
CLEAN_VERSION
make[1]: *** No rule to make target 'list.o', needed by 'cf2.elf'. Stop.
make: *** [Makefile:380: build] Error 2
This does not make it super clear that it is the missing submodules that
is at fault.
This commit adds a check for the vendor submodules and will produce an
error if missing, like so:
$ make
Makefile:383: ***
The submodules does not seem to be present, consider fetching them by:
$ git submodule init
$ git submodule update
. Stop.
jonasdn
force-pushed
the
jonasdn/error-submodules
branch
from
b78cbed to
c996bee
Compare
|
Another way to tackle this would be to just fetch the submodules if they are not there on |
cafeciaojoe
pushed a commit
to cafeciaojoe/crazyflie-firmware
that referenced
this pull request
Sep 27, 2024
…r_config inputconfigdialogue: Update buttonrole enum to pyqt6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you, like me, fail to read the README.md properly you will get a bit of a cryptic error when trying to build.
This does not make it super clear that it is the missing submodules that is at fault.
This PR adds a check for the vendor submodules and will produce an error if missing, like so: