Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ASSERT error handling and reporting #548

Merged

Conversation

whoenig
Copy link
Contributor

@whoenig whoenig commented Feb 4, 2020

  • Motors are now disabled after an assert. This is in particular
    important if the watchdog is disabled.
  • ASSERT information is now stored for FreeRTOS related issues
    (out of memory, stack overflow). Note that the stack overflow
    detection has to be enabled manually for release builds.
  • HardFault asserts now include more detailed information, e.g.,
    the program counter. One can use GDB to find the source code
    line that triggered a hard fault.

* Motors are now disabled after an assert. This is in particular
  important if the watchdog is disabled.
* ASSERT information is now stored for FreeRTOS related issues
  (out of memory, stack overflow). Note that the stack overflow
  detection has to be enabled manually for release builds.
* HardFault asserts now include more detailed information, e.g.,
  the program counter. One can use GDB to find the source code
  line that triggered a hard fault.
@krichardsson krichardsson merged commit 030de69 into bitcraze:master Feb 5, 2020
@krichardsson
Copy link
Contributor

Nice, thanks!

@whoenig whoenig deleted the feature-improved-error-handling branch February 5, 2020 18:52
@krichardsson
Copy link
Contributor

@whoenig I just realized that there is already a function for turning off the motors. In power_distribution_stock.c, there is powerStop() function that does the same thing as the new powerStop() in motors.c.

whoenig added a commit to whoenig/crazyflie-firmware that referenced this pull request Feb 7, 2020
@whoenig
Copy link
Contributor Author

whoenig commented Feb 7, 2020

Sorry about that - see #550 for a fix.

@krichardsson krichardsson added this to the next-release milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants