Fix HardFault in Logging #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging subsystem could trigger a hard fault caused by unaligned assignment "variable = *(float *)ops->variable;". This issue can be reproduced with the crazyswarm_master firmware when connecting to the cfclient. The fix uses lowlevel memcpy to a local (aligned) variable before assignment.
|
I though CM-4 allowed unaligned access so this is surprising, but after checking it seems that un-aligned access only work for some instructions. |
cafeciaojoe
pushed a commit
to cafeciaojoe/crazyflie-firmware
that referenced
this pull request
Sep 27, 2024
cafeciaojoe
pushed a commit
to cafeciaojoe/crazyflie-firmware
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging subsystem could trigger a hard fault caused by unaligned assignment "variable = *(float *)ops->variable;".
This issue can be reproduced with the crazyswarm_master firmware when connecting to the cfclient.
The fix uses lowlevel memcpy to a local (aligned) variable before assignment.