Automatically disarm after N seconds without flying #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting idle thrust no longer automatically enables manual arming
ataffanel
requested changes
Dec 9, 2024
There was a problem hiding this comment.
The change looks good to me. 30s might be a good time to start with.
About the spamming: what about not printing arming states only when auto-arming is enabled. We can just write in the console that auto-arming is enabled and nothing else.
Otherwise this looks good to merge to me!
Crashed and locked are already covered with other prints, so the only case this uniquely covers is being tumbled (CF lingo for upside down). This should be obvious to the user and requires nothing other than putting the Crazyflie upright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces automatic disarming of the Crazyflie if no flight is started within 30 seconds after arming. This time-out is configurable. Implementation largely identical to post-flight auto-disarming.
Since we currently print to console when ready to fly and when disarming, this introduces "spam" to the console when using auto-arming. Considering removing these printouts.
Possible discussion points: