PID avoid derivative kick #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR and sorry for the delay! Since this is an intricate change we do need to test it out here at the office in flight and discuss it on our next triage, so please bear with us for a little longer for the review. |
|
Hi, Kimberly! No worries for the late reply, it was not the best time to propose a PR like this one. Perhaps I should have opened a branch for easier testing, I'm not sure how you proceed. Happy to further discuss or develop if any issues are encountered while testing. |
|
I finally came around to test this in flight! Seems that the controller seems to work all fine so I'll jus go ahead and merge this. Thanks! |
knmcguire
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1336