Remove "charger connected" from supervisor #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the supervisor checks if we are connected to a chargers, the idea being that we should not try to fly when connected to USB.
The problem is that It is not possible to detect if a USB cable is connected (due to hardware) and currently the check actually means something closer to "are we charging". The problem is that this also includes the Qi charger which prevents take-offs when charging on a charging pad.
This PR removes all charging related functionatlity from the supervisor.
The PR also includes some improved logging, including a dump of the supervisor state.