Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log instead of assert on CPX version mismatch #1265

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

krichardsson
Copy link
Contributor

Related to #1253

It has turned out that asserting on CPX version mismatch is a bad idea, as it restarts the STM and prevents flashing of the ESP.
This PR chantes the behavior to logging the problem and ignoring packets with the wrong version.

@krichardsson krichardsson merged commit 43a45c7 into master Apr 12, 2023
@krichardsson krichardsson deleted the krichardsson/cpx-version-fix branch April 12, 2023 13:12
@krichardsson krichardsson added this to the next-release milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant