Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #1221

Merged
merged 23 commits into from
Feb 9, 2023
Merged

Housekeeping #1221

merged 23 commits into from
Feb 9, 2023

Conversation

valeriyvan
Copy link
Contributor

No description provided.

@krichardsson
Copy link
Contributor

krichardsson commented Feb 8, 2023

Great stuff!
It is better to group multiple spelling changes into one PR, like this.

The only issue with this PR is the renaming of appchannelHasOverflowOccured() to appchannelHasOverflowOccurred(). This function is part of a stable app API (that's why it is called from app_api/src, to remind us) and the idea is that we will not change these functions without first deprecating them for a while. The renaming is good, but we must also keep the old function with a deprecation comment, see appchannelReceivePacket() for a similar case.

@valeriyvan
Copy link
Contributor Author

Great stuff! It is better to group multiple spelling changes into one PR, like this.

The only issue with this PR is the renaming of appchannelHasOverflowOccured() to appchannelHasOverflowOccurred(). This function is part of a stable app API (that's why it is called from app_api/src, to remind us) and the idea is that we will not change these functions without first deprecating them for a while. The renaming is good, but we must also keep the old function with a deprecation comment, see appchannelReceivePacket() for a similar case.

done

@krichardsson krichardsson merged commit 308950c into bitcraze:master Feb 9, 2023
@krichardsson
Copy link
Contributor

Thanks!

krichardsson added a commit that referenced this pull request Feb 9, 2023
@valeriyvan valeriyvan deleted the typos branch February 15, 2023 07:55
@krichardsson krichardsson added this to the 2023.02 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants