Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kalman estimator #1194

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Refactor kalman estimator #1194

merged 2 commits into from
Jan 24, 2023

Conversation

krichardsson
Copy link
Contributor

This PR contains refactoring of the kalman estimator to make it easier to run it from python bindings.

The code in estimator_kalman.c must be re-implemented (with modifications) in python when running thrugh the bindings as this code has lots of dependencies to FreeRTOS. The chaninges in this PR aims at moving as much as possible to the kalman core and other portable core to minimize and simplify the code that must be re-implemented.

Main changes:

  • Add sub sampler for gyro and accelerometer
  • Change all times in kalman core and related files from ticks to ms
  • Make sure kalman core knows whether it has been updated and should be finalized (used to be handled outside)
  • Make the kalman core aware of when it was previously updated to enable it to compute delta time

@knmcguire knmcguire self-requested a review January 23, 2023 15:22
@knmcguire
Copy link
Member

I'll take a look now and review it.

@whoenig this might be of interest to you too since is meant for the estimator pythonbindings

@knmcguire
Copy link
Member

Me and @krichardsson has gone through it as the github difference is messing some parts up. But it checks out and it builds, but it still needs to be flighttested by @krichardsson

Copy link
Member

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the requirement that it needs to be flighttested

@krichardsson
Copy link
Contributor Author

Flight tested OK

@knmcguire knmcguire merged commit 4c34965 into master Jan 24, 2023
@knmcguire knmcguire deleted the krichardsson/refactor-kalman branch January 24, 2023 14:47
@krichardsson krichardsson added this to the 2023.02 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants