Bigquad early access fix #1131
Merged
Bigquad early access fix #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interpreted as system voltage when. This can be handy for BQD.
in Kconfig instead of in source code. Added them as mili Volts/Amps, because kbuild does not support floats.
PM status to easier decide what power state we should be in, regardless of platform. We still need to know if we're using the BQD though.
tobbeanton
requested changes
Oct 7, 2022
src/hal/src/pm_stm32f4.c
Outdated
|
|
||
| if (isPgood && !isCharging) | ||
| if (usingBigQuadDeck) |
There was a problem hiding this comment.
I would like to remove this dependency and have the BiqQuaddeck driver call a function to enable this behavior instead. Something like pmIgnoreChargedState()
Made BQD driver call into pm instead to ignore charging/charged state, which is needed for correct low-battery warnings when using BQD.
|
I agree that it makes more sense to not have the dependency in the |
tobbeanton
approved these changes
Oct 14, 2022
|
The merge of PR #1132 might create some conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled external battery voltage measurements to be used as system votlage (useful for Big Quad deck).
Updated power state handling to support lowPower state regardless of platform and if Big Quad deck is connected.
Moved constants from source code to kbuild.