Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved support extRx (CPPM) #1121

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Improved support extRx (CPPM) #1121

merged 1 commit into from
Oct 5, 2022

Conversation

matejkarasek
Copy link
Contributor

@matejkarasek matejkarasek commented Sep 29, 2022 •
edited
Loading

This PR improves the support of external CPPM receivers:

  • enabling rate mode
  • reusing "cmdrCPPM" permanent parameters also for extRx channel scaling (until now used only for CRTP packets with emulated CPPM channels). New name "cppm" instead of "cmdrCPPM" is proposed
  • pin configuration moved to Kconfig
  • enabling Althold, Arming and Mode switches moved to Kconfig
  • enabling TAER mapping moved to Kconfig

@matejkarasek matejkarasek mentioned this pull request Sep 29, 2022
Closed
@krichardsson
Copy link
Contributor

I think this looks good, but on the other hand I'm not an expert for this code :-)
@tobbeanton do you have any input?

@tobbeanton
Copy link
Member

I also think it looks good. Currently don't have the possibility to test it but I guess you did @matejkarasek. If so it is good to merge for me.

@krichardsson krichardsson merged commit 252de99 into bitcraze:master Oct 5, 2022
@krichardsson
Copy link
Contributor

Merged. Thanks!

@matejkarasek
Copy link
Contributor Author

Yes, the code is tested.
Thanks!

@matejkarasek matejkarasek mentioned this pull request Oct 7, 2022
Merged
@krichardsson krichardsson added this to the 2022.12 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022.12
Development

Successfully merging this pull request may close these issues.
3 participants
@matejkarasek @krichardsson @tobbeanton