-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiranger discard range measurements larger with bad status #1088
Conversation
@@ -96,7 +96,11 @@ static uint16_t mrGetMeasurementAndRestart(VL53L1_Dev_t *dev) | |||
} | |||
|
|||
status = VL53L1_GetRangingMeasurementData(dev, &rangingData); | |||
range = rangingData.RangeMilliMeter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the most important change, the rest is just formatting
with discussion with @krichardsson, we decided to add a parameter which presents a filter flag, that indicates for which statuses the measurement, if it should let the measurement through or not, based on these values: crazyflie-firmware/src/lib/vl53l1/core/inc/vl53l1_def.h Lines 502 to 535 in 46f497a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
This should fix #874. Here in the multiranger, it will first check if the vl53l1 returns a valid range measurements status, and if not it will output the maximum value of an int16_t
Two questions here: