Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kconfig updates #1056

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Kconfig updates #1056

merged 3 commits into from
Jun 8, 2022

Conversation

krichardsson
Copy link
Contributor

This PR fixes some issues in the Kconfig setup found in #1054

@krichardsson
Copy link
Contributor Author

For the estimator and controller settings the changes are pretty straight forward, simply set the appropriate estimator or controller config to y in the default config files. For instance

CONFIG_ESTIMATOR_ANY=y

If the kalman estimator is required, one would use

CONFIG_ESTIMATOR_KALMAN=y

@krichardsson
Copy link
Contributor Author

The deck force parameter requires double quoting, for instance

CONFIG_DECK_FORCE="bcDWM1000:myOtherDeck"

@krichardsson
Copy link
Contributor Author

I changed the power distribution a bit. I could not figure out a way to use kbuild in a similar way as we did earlier (with a config the names the file to use in the build). Instead I added a power distribution choice to the configuration that only contains the normal quad power distribution. If someone wants a new power distribution for a new platform, a new option can be added to the choice that is used to build the correct file. The setup is documented in the docs files.

@krichardsson krichardsson marked this pull request as ready for review June 8, 2022 12:21
@krichardsson krichardsson requested a review from tobbeanton June 8, 2022 12:22
Copy link
Member

@tobbeanton tobbeanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to comment on really, looks nice and good with some CF1 cleanup!

@tobbeanton tobbeanton merged commit 144e094 into master Jun 8, 2022
@krichardsson krichardsson deleted the krichardsson/kconfig-fixes branch June 9, 2022 08:17
@krichardsson krichardsson added this to the 2022.09 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants