Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin indexmap to 2.5.0 for MSRV #5

Closed
wants to merge 29 commits into from
Closed

ci: pin indexmap to 2.5.0 for MSRV #5

wants to merge 29 commits into from

Conversation

ValuedMammal
Copy link

No description provided.

praveenperera and others added 29 commits October 15, 2024 12:50
@praveenperera
Remove hard dependency on async-std, allow selecting tokio or async-std
298d900
@praveenperera
Make tokio a default feature
da8b6dd
@praveenperera
Make sleep into a trait
26bd129
@praveenperera
Add tests and make sure it works with a custom runtime
54a33d5
@praveenperera
Remove outdated info from README
8aa83b2
@praveenperera
Change builder to not need runtime struct to be passed in
35b6377
@praveenperera
Remove async-std default runtime support
1eccf7c
@praveenperera
Undo reqwest upgrade
e97175c
@praveenperera
Rename runtime module and trait to sleeper
0f01dce
@praveenperera
Use shorter trait bound syntax
6d69cbf
@praveenperera
Fix custom runtime test
06159c4
@praveenperera
Fix tests without default features
d248d90
@praveenperera
Dowgrade tokio dep for MSRV 1.63
361c719
@praveenperera
Derive Debug, Clone and Copy for DefaultSleeper
6159908
@praveenperera
Move Builder methods that don't require a trait bound to generic impl
2a453c3
@praveenperera
Add async-trait as an optional dep for async
2d5b0a8 
Can remove this when MSRV is bumped to >=1.75
@praveenperera
Don't require async_trait in Sleeper trait if not async
abf7de1
@praveenperera @ValuedMammal
Update src/lib.rs
69cb5bd 
Co-authored-by: ValuedMammal <[email protected]>
@praveenperera
Only use Sleeper trait if async feature is enabled
f98a0bd
@praveenperera
Only bring in sleeper in async feature is enabled
7228840
@praveenperera
Fix for blocking feature
0d31bd8
@praveenperera
Bring DefaultSleeper into lib
a59b878
@praveenperera
Use async-trait in test
083509a
@praveenperera @tnull
Update Cargo.toml
f1a684a 
Co-authored-by: Elias Rohrer <[email protected]>
@praveenperera
Move Sleeper trait to async module
7c27c63
@ValuedMammal
review 103
8dce43f 
- Remove generic S from Builder
- Add documentation
@praveenperera
Merge pull request bitcoindevkit#4 from ValuedMammal/review/103
ca6cfe8 
Review 103
@praveenperera
Remove use for async-trait and improve docs and feature usage
15a2592
@ValuedMammal
ci: pin indexmap to 2.5.0 for MSRV
8eaddbd
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11727514696

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.677%
Totals Coverage Status
Change from base Build 11711603550: 0.0%
Covered Lines: 1053
Relevant Lines: 1201
💛 - Coveralls

@ValuedMammal ValuedMammal deleted the review/103 branch November 12, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValuedMammal @coveralls @praveenperera