Skip to content

Commit

Permalink
Merge bitcoindevkit#128: ci: add test with MSRV 1.63.0
Browse files Browse the repository at this point in the history
4b42108 ci: add test with MSRV 1.63.0 (Steve Myers)

Pull request description:

  Since the main BDK crates are changing to MSRV 1.63.0 as is LDK the CI for this project should also have an MSRV and test against it in CI.

  Also rustc 1.63 is the version shipped with the current debian stable (bookworm): https://packages.debian.org/stable/rust/rustc

ACKs for top commit:
  oleonardolima:
    utACK 4b42108
  storopoli:
    ACK 4b42108
  ValuedMammal:
    ACK 4b42108 looks good to me

Tree-SHA512: baff75887008a586af0ef0c4f50dd8c7c3de782f2dc6bc7d94c072c95205d4ef1a339860b3674dd781ad5558b98b071ed49b3a48507219b747e14c394dfe0a7b
  • Loading branch information
notmandatory committed May 28, 2024
2 parents 1899234 + 4b42108 commit 64c77ee
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/cont_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@ on: [push, pull_request]
name: CI

jobs:

test-fmt:
name: Test
runs-on: ubuntu-20.04
env:
TEST_ELECTRUM_SERVER: electrum.blockstream.info:50001
#TEST_ELECTRUM_SERVER: bitcoin.aranguren.org:50001
strategy:
matrix:
rust:
- stable # STABLE
- 1.63.0 # MSRV
steps:
- name: Checkout
uses: actions/checkout@v2
Expand All @@ -24,7 +28,7 @@ jobs:
- name: Install rustup
run: curl https://sh.rustup.rs -sSf | sh -s -- -y
- name: Set default toolchain
run: $HOME/.cargo/bin/rustup default stable
run: $HOME/.cargo/bin/rustup default ${{ matrix.rust }}
- name: Set profile
run: $HOME/.cargo/bin/rustup set profile minimal
- name: Fmt
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ documentation = "https://docs.rs/electrum-client/"
description = "Bitcoin Electrum client library. Supports plaintext, TLS and Onion servers."
keywords = ["bitcoin", "electrum"]
readme = "README.md"
rust-version = "1.63.0"

# loosely based on https://github.com/evgeniy-scherbina/rust-electrumx-client

Expand Down
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# rust-electrum-client [![Build Status]][GitHub Workflow] [![Latest Version]][crates.io]
# rust-electrum-client
[![Build Status]][GitHub Workflow] [![Latest Version]][crates.io] [![MSRV Badge]][Rust Blog]

[Build Status]: https://github.com/bitcoindevkit/rust-electrum-client/actions/workflows/cont_integration.yml/badge.svg
[GitHub Workflow]: https://github.com/bitcoindevkit/rust-electrum-client/actions?query=workflow%3ACI
[Latest Version]: https://img.shields.io/crates/v/electrum-client.svg
[crates.io]: https://crates.io/crates/electrum-client
[MSRV Badge]: https://img.shields.io/badge/rustc-1.63.0%2B-lightgrey.svg
[Rust Blog]: https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html

Bitcoin Electrum client library. Supports plaintext, TLS and Onion servers.

0 comments on commit 64c77ee

Please sign in to comment.