Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter-280: translate into Chinese #1435

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Newsletter-280: translate into Chinese #1435

merged 1 commit into from
Dec 18, 2023

Conversation

hulatown
Copy link
Contributor

No description provided.

@cryptozyu @hulatown
@editor-Ajian @freeyao
newsletter-280: translate into Chinese (#88)
2bf1188 
* newsletter-280: translate into Chinese

* Apply suggestions from code review

Co-authored-by: editor-Ajian <[email protected]>

* fix style

* Apply suggestions from code review

Co-authored-by: freeyao <[email protected]>

---------

Co-authored-by: Zhiwei(Jeffrey) Hu <[email protected]>
Co-authored-by: editor-Ajian <[email protected]>
Co-authored-by: freeyao <[email protected]>
@hulatown
Copy link
Contributor Author

hulatown commented Dec 17, 2023 •
edited
Loading

Hi! I can pass the check by make production on my local environment. But it seems failed with Travis CI. Do you know what the reason might be and how I could fix it? Thanks

@bitschmidty bitschmidty mentioned this pull request Dec 18, 2023
Open
@bitschmidty
Copy link
Contributor

Hi! I can pass the check by make production on my local environment. But it seems failed with Travis CI. Do you know what the reason might be and how I could fix it? Thanks

Ive opened an issue for this and began work on a fix which is more complicated since it involves upgrading to ruby 3.x.

bitschmidty
bitschmidty approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, checked links and formatting.

Ive also run travis-related checks locally to ensure that they pass.

Thank you @hulatown !

@bitschmidty bitschmidty merged commit 3c698b6 into bitcoinops:master Dec 18, 2023
1 of 2 checks passed
@bitschmidty bitschmidty mentioned this pull request Dec 18, 2023
Merged
@hulatown hulatown deleted the newsletter280d1 branch December 19, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitschmidty bitschmidty bitschmidty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hulatown @bitschmidty @cryptozyu