Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taproot multisig with verified unspendable internalPubkey example #2112

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

junderw
Copy link
Member

@junderw junderw commented Jun 15, 2024

@motorina0 @jasonandjay Please review when you have time.

@motorina0 I wonder if we can modify PSBT in a way that automates the dummy signature process during finalization?

At the very least maybe we can make it easier to create and insert the dummies... this feels pretty awkward.

Also, "Nothing Up My Sleeve" internal key is not easy to understand or come across if you only read our examples and code, maybe this can be baked into a new payment someday... like p2trms or something.

@junderw junderw requested a review from motorina0 June 15, 2024 02:46
@junderw junderw force-pushed the example/multisigtaproot branch 2 times, most recently from 7eba022 to f47bd05 Compare June 15, 2024 08:51
@junderw
Copy link
Member Author

junderw commented Jul 3, 2024

I'm going to merge this as-is.

The dummy signature thing is a bit of a sore spot, but since we don't officially support this and it's just a simple example, anyone who wants to do this can look at the example and do it themselves.

@junderw junderw merged commit 8edc5e8 into master Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants