Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant code #1991

Merged
merged 1 commit into from
Oct 12, 2023
Merged

remove redundant code #1991

merged 1 commit into from
Oct 12, 2023

Conversation

jasonandjay
Copy link
Member

  1. extract stacksEqual
  2. decode P2TR address with fromBech32
  3. convergence hashType judgment to isDefinedHashType

I think its necessary to remove some redundant code while adding document comment to avoid repeat comment

@jasonandjay
remove redundant code
c4dbe6f 
1. extract stacksEqual
2. decode P2TR address with fromBech32
3. convergence hashType judgment to isDefinedHashType
junderw
junderw approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junderw junderw merged commit 6e6b889 into bitcoinjs:master Oct 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonandjay @junderw