Add RBF Parameter Support to PSBT Inputs, Update Dependencies, and Set RBF Default to True #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces support for the
rbf
parameter in theupdatePsbtAsInput
method, allowing users to specify whether a transaction should use Replace-By-Fee (RBF). The update ensures that transactions utilizing relative timelocks automatically opt into RBF unless explicitly disabled. Key changes include:rbf
parameter inupdatePsbtAsInput
.rbf
parameter.@bitcoinerlab/miniscript
and@bitcoinerlab/secp256k1
.rbf
parameter now defaults totrue
, differing from previous versions where it was not explicitly set.Details
README Update: Detailed the usage of the
rbf
parameter inupdatePsbtAsInput
, including its default behavior and implications for transactions using relative timelocks.Descriptor Changes:
rbf
parameter handling inupdatePsbtAsInput
.PSBT Changes:
rbf
parameter.Dependency Updates:
@bitcoinerlab/miniscript
to version1.4.0
.@bitcoinerlab/secp256k1
to version1.1.1
.Default Behavior Change:
rbf
parameter now defaults totrue
, which changes the default behavior from previous versions where it was not explicitly set. This ensures that transactions are replaceable by default unless specified otherwise.Notes
nSequence < 0x80000000
) inherently opt into RBF due to the overlapping nSequence value ranges.rbf
parameter is optional and defaults totrue
, ensuring backward compatibility.This update provides more control over transaction fee adjustments and ensures correct behavior with relative timelocks.