Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 0.8.0, bump MSRV to 1.63.0 #97

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 22, 2024

We need to publish a new version with the rust-bitcoin/miniscript version bump.

I also updated the MSRV for this project to 1.63.0 to match other BDK projects and so I could remove the version pinning that wasn't working anymore.

@oleonardolima
Copy link
Contributor

oleonardolima commented Mar 22, 2024

Is the CI expected to fail ?

I think it's related to Update Toolchain step, as it's updating to rust 1.77 IIUC 🤔

@notmandatory notmandatory changed the title Update version to 0.8.0 Update version to 0.8.0, bump MSRV to 1.63.0 Mar 22, 2024
@notmandatory
Copy link
Member Author

Is the CI expected to fail ?

No it shouldn't fail. I've fixed it now by bumping the projects MSRV to 1.63 so I don't need to troubleshoot new version pinning issues.

@notmandatory notmandatory self-assigned this Mar 22, 2024
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0c9e5c0

Copy link

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0c9e5c0

@notmandatory notmandatory merged commit def31bb into bitcoindevkit:master Mar 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants