chore: Enforce min rustls version to 0.23.19
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
bump_rustls_version
branch
from
2e605e1 to
dac38c0
Compare
3 tasks
ValuedMammal
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Nov 29, 2024
8e5a7c6 chore: Revert `rustls` pin dependency (志宇) Pull request description: ### Description The recent release of `rustls` (0.23.19) reverts it's MSRV to 1.63 so the pin is no longer necessary. ### Notes to the reviewers Some context: * bitcoindevkit/rust-electrum-client#158 * rustls/rustls#2244 ### Changelog notice * Revert MSRV pin of `rustls`. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: LagginTimes: ACK 8e5a7c6 ValuedMammal: ACK 8e5a7c6 Tree-SHA512: 355291f93a879effc8aa1d7fe0254d8f879f26d06f0d6b0ad3d7a508a53179f7c5b9ebcd2d450ee042fbd2867119cf9a15c3193af6f36c3e5548634ce689cdca
oleonardolima
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
tACK dac38c0
You'd still need to update the rustls version on README.md too.
`rustls` versions 0.23.18 and 0.23.19 contains fix for vulnerability RUSTSEC-2024-0399. However, 0.23.18 bumps MSRV to 1.71. 0.23.19 reverts MSRV back to 1.63. We enforce min `rustls` version to 0.23.19 to make it easier to compile on MSRV and ensure we include the RUSTSEC-2024-0399 fix. Note that in CI, I decided to pin `rustls` dependency to 0.23.19 explicitly. This is because in future versions of `rustls`, the MSRV will be changed to 1.71.
notmandatory
force-pushed
the
bump_rustls_version
branch
from
dac38c0 to
7ef3ff6
Compare
notmandatory
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
ACK ed0cdae
Thanks for fixing this up, I went ahead and updated the README and bumped the patch version so it's ready to release.
notmandatory
force-pushed
the
bump_rustls_version
branch
from
527cb61 to
ed0cdae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustlsversions 0.23.18 and 0.23.19 contains fix for vulnerability RUSTSEC-2024-0399. However, 0.23.18 bumps MSRV to 1.71. 0.23.19 reverts MSRV back to 1.63.We enforce min
rustlsversion to 0.23.19 to make it easier to compile on MSRV and ensure we include the RUSTSEC-2024-0399 fix.Note that in CI, I decided to pin
rustlsdependency to 0.23.19 explicitly. This is because in future versions ofrustls, the MSRV will be changed to 1.71.Context: rustls/rustls#2244