Expose more getters in Wallet and other useful descriptor traits #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afilini
force-pushed
the
feature/more-getters
branch
2 times, most recently
from
3b13941 to
86eb0c5
Compare
LLFourn
reviewed
Mar 10, 2022
15 tasks
afilini
force-pushed
the
feature/more-getters
branch
from
86eb0c5 to
36dd65d
Compare
afilini
changed the title
afilini
force-pushed
the
feature/more-getters
branch
4 times, most recently
from
80f7e0d to
b5cb0f7
Compare
There was a problem hiding this comment.
ACK b5cb0f7
Code changes looks good to me. Tried the doc example and it works. Agree with the idea to expose more descriptor level functionality to users..
Below are few comments and questions
afilini
force-pushed
the
feature/more-getters
branch
from
b5cb0f7 to
519ebe3
Compare
afilini
force-pushed
the
feature/more-getters
branch
from
519ebe3 to
11c091e
Compare
|
It looks like this one is ready for the next release, @rajarshimaitra or @LLFourn since you've both taken a look already would one of your like to approve it? |
rajarshimaitra
approved these changes
Apr 4, 2022
notmandatory
force-pushed
the
feature/more-getters
branch
from
11c091e to
cc4dbf0
Compare
notmandatory
force-pushed
the
feature/more-getters
branch
from
cc4dbf0 to
1b90148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose more getters and internal utilities for people who need to work with descriptors.
A good example of how this can be leveraged is in the second commit, which refactors the wallet export functionality to use the new public APIs rather than using members on
Walletdirectly.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md