feat(chain,wallet)!: Transitive ChainPosition
#1733
Draft
+237
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/chain/src/chain_data.rs
Outdated
Comment on lines
32
to
33
| /// It may be possible that the chain data was last seen as confirmed in a conflicting | ||
| /// chain. |
There was a problem hiding this comment.
Would this more clearly describe when this value is Some or None?
Suggested change
| /// It may be possible that the chain data was last seen as confirmed in a conflicting | |
| /// chain. | |
| /// If the value is `Some` then this is when the chain data was last seen in a mempool. | |
| /// If `None` then it was only seen as confirmed in a conflicting chain. |
There was a problem hiding this comment.
/// When the chain data is last seen in the mempool.
///
/// This value will be `None` if the chain data was never seen in the mempool and only seen
/// in a conflicting chain.
How about this?
There was a problem hiding this comment.
Yes this is clear and more concise.
Change `ChainPosition` to be able to represent transitive anchors and unconfirm-without-last-seen values.
evanlinjin
force-pushed
the
feature/transitive_chain_position
branch
from
374097d
to
1fb4428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
ChainPositionto be able to represent transitive anchors and unconfirm-without-last-seen values.As mentioned in #1670 (comment)
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: