docs: to README.md add tests troubleshooting (run in series) #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
Comment on lines
85
to
86
| If tests are failing with `cargo test` it could be an issue related to tests that use bitcoind or electrsd running in parallel. To force tests to run in series you can try: | ||
|
|
There was a problem hiding this comment.
Do you know if anyone else faced this on Linux? I guess it's a macOS-related issue, maybe we should point that out here?
There was a problem hiding this comment.
I am having this issue on mac, however I have no idea if it's exclusive to mac so it's probably worth being aware of for anyone who's having issues running the tests
There was a problem hiding this comment.
went ahead and added a note that it's known to affect mac users
riverKanies
force-pushed
the
docs/add-troubleshooting-tests-to-readme
branch
from
4cbab45
to
6c80080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #1723
Shows how to force tests to run in series (rather than parallel) in case of issues running tests that use bitcoind or electrsd
Notes to the reviewers
Can also enforce running in series like #1728
I figured it wouldn't hurt to add this to the README.md anyway so made a PR for both
Bugfixes: