-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bdk_wallet version to 1.0.0-beta.3 #1608
Bump bdk_wallet version to 1.0.0-beta.3 #1608
Conversation
Also, couldn't we only bump the minor version of chain sources as well? |
If we know it's a non-breaking change then I agree it should only be a patch release bump. @ValuedMammal introduced me to the |
bdk_core to 0.1.1 bdk_chain to 0.18.1 bdk_bitcoind_rpc to 0.14.1 bdk_electrum to 0.17.1 bdk_esplora to 0.17.1 bdk_file_store to 0.15.1 bdk_testenv to 0.8.1
ea711af
to
7a501c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7a501c1
I think |
The |
I can confirm that
Sometimes |
@storopoli oh shoot! does this happen even if you do a |
I'm going to re-release a minor bump for all crates that have changes and yank the old versions. |
Apologies for the version mistake |
Much better we try new things during the beta releases and figure out the issues now! IMO the real issue is we need contributors who make breaking changes to figure out the the version bumping so we as release managers don't have to think about it. See my suggestion here: #1521 (comment) |
Yes, commits that are breaking must include I think the problem is with tooling. To figure out if a certain crate has breaking changes, we can iterate through the commit descriptions from the last release, find all commits with |
I don't think we should rely on |
Description
Bump bdk_wallet version to 1.0.0-beta.3
bdk_core to 0.1.1
bdk_chain to 0.18.1
bdk_bitcoind_rpc to 0.14.1
bdk_electrum to 0.17.1
bdk_esplora to 0.17.1
bdk_file_store to 0.15.1
bdk_testenv to 0.8.1