-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(electrum): Test sync in reorg and no-reorg situations #1535
test(electrum): Test sync in reorg and no-reorg situations #1535
Conversation
a15f6f3
to
01f5a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work with this. Moving forward, I recommend improving the docs and adding more clarity to the testing logic. I also included a bunch of nits for you to consider including.
a47b802
to
c080123
Compare
The commit also adds a method to the |
f274e4c
to
ff3f5da
Compare
ff3f5da
to
13ebe13
Compare
360a78c
to
73e34ec
Compare
Add test for `bdk_electrum` to make sure previously unconfirmed transactions get confirmed again in both reorg and no-reorg situations.
73e34ec
to
df80a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once these are addressed and changelog is added to PR description, I am happy to merge.
Added `wait_until_electrum_sees_txid` method to `TestEnv`. Both `bdk_electrum` wait methods now have a `timeout` option. Removed the exponential polling delay in lieu of a fixed delay inside the `bdk_electrum` wait methods.
df80a0f
to
2c0bc45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2c0bc45
|
||
assert_eq!( | ||
get_balance(&recv_chain, &recv_graph)?, | ||
Balance { | ||
trusted_pending: SEND_AMOUNT * depth as u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #1125.
Description
Add new test for
bdk_electrum
to make sure previously unconfirmed transactions get confirmed again in both reorg and no-reorg situations.Changelog notice
wait_until_electrum_sees_txid
method toTestEnv
.wait_until_electrum_sees_block
now has aDuration
input for timeout.wait_until_electrum_sees_block
.test_sync
tobdk_electrum
to make sure previously unconfirmed transactions get confirmed in both reorg and no-org situations.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing