chore: fix clippy lints #1530
Merged
chore: fix clippy lints #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
storopoli
commented
Jul 30, 2024
| @@ -93,7 +93,6 @@ impl ChangeSet { | |||
| Self::init_wallet_sqlite_tables(db_tx)?; | |||
| use chain::rusqlite::OptionalExtension; | |||
| use chain::Impl; | |||
| use miniscript::{Descriptor, DescriptorPublicKey}; | |||
There was a problem hiding this comment.
already imported in the module.
LagginTimes
pushed a commit
to LagginTimes/bdk
that referenced
this pull request
Aug 8, 2024
8bf8c7d chore: fix clippy lints (Jose Storopoli) Pull request description: ### Description Fix some clippy CI lints ### Notes to the reviewers More caught by the Nix CI in bitcoindevkit#1320. ### Changelog notice chore: clippy lints ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: notmandatory: ACK 8bf8c7d Tree-SHA512: 6b53cb739e506d79106a2f42aa2b8fa28ef226543fbbf100225f10ed82257f6fd0218f09c0f1291803fbc9c1c88e32ba1c7e02fe3f601ccc9dc5be8a6efea6e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some clippy CI lints
Notes to the reviewers
More caught by the Nix CI in #1320.
Changelog notice
chore: clippy lints
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: