Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Update example_cli and retire old nursery crates #1495

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Jul 1, 2024

  • Adds two commands init and generate. Loading database doesn't require descriptors
  • Replaces send command with psbt (new, sign, and extract). Supports tap key spend
  • Uses bdk-coin-select and miniscript plan module

fixes #1469
partially addresses #1462

Notes to the reviewers

Note the example_cli lib now defines the ChangeSet and Anchor type whereas before these were generic

Changelog notice

  • Improvements to example_cli that include generating descriptors and creating PSBTs

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@storopoli
Copy link
Contributor

We could merge this with #1442 and then commit it as a single PR?

If favorable I could rebase #1442 and then you can commit on top of that? Or I can do the opposite as well...

@ValuedMammal
Copy link
Contributor Author

1442 can be merged anytime and from what I can tell doesn't conflict with this one

@rustaceanrob
Copy link
Contributor

Nice. This cleans things up quite a bit.

@ValuedMammal ValuedMammal marked this pull request as ready for review July 12, 2024 16:15
@ValuedMammal
Copy link
Contributor Author

  • Rebased onto 17a9850
  • For now I'm using bdk_wallet::ChangeSet for the example-cli
  • Added back support for single descriptor use
  • CI failed to build msrv

Copy link
Contributor

@LLFourn LLFourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConceptACK this looks great.

@ValuedMammal ValuedMammal force-pushed the example/cli branch 2 times, most recently from a889259 to 382d07b Compare July 28, 2024 15:32
@ValuedMammal ValuedMammal changed the title Upgrade example_cli example: Update example_cli and retire old nursery crates Aug 4, 2024
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 771f6b9

A lot better than what we had before. Made the examples a lot more useful.

@evanlinjin evanlinjin merged commit 98c4959 into bitcoindevkit:master Aug 12, 2024
12 checks passed
@ValuedMammal
Copy link
Contributor Author

Thanks @evanlinjin @LLFourn

We're currently limited to creating PSBTs for wpkh and tr descriptors because I got stuck on trying to add assets/keys for wsh (can still sync and derive addresses though).

@evanlinjin
Copy link
Member

@ValuedMammal I think that's fine for now, can add them later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove nursery/tmp_plan
6 participants