-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: Update example_cli
and retire old nursery crates
#1495
Conversation
1442 can be merged anytime and from what I can tell doesn't conflict with this one |
Nice. This cleans things up quite a bit. |
de2ea75
to
89959dc
Compare
fe0215f
to
6748db3
Compare
6748db3
to
083f709
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConceptACK this looks great.
a889259
to
382d07b
Compare
382d07b
to
771f6b9
Compare
example_cli
and retire old nursery crates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 771f6b9
A lot better than what we had before. Made the examples a lot more useful.
Thanks @evanlinjin @LLFourn We're currently limited to creating PSBTs for |
@ValuedMammal I think that's fine for now, can add them later |
init
andgenerate
. Loading database doesn't require descriptorssend
command withpsbt
(new, sign, and extract). Supports tap key spendbdk-coin-select
and miniscriptplan
modulefixes #1469
partially addresses #1462
Notes to the reviewers
Note the
example_cli
lib now defines theChangeSet
andAnchor
type whereas before these were genericChangelog notice
example_cli
that include generating descriptors and creating PSBTsChecklists
All Submissions:
cargo fmt
andcargo clippy
before committing